From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Surbhi Palande <Surbhi.Palande@canonical.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable@kernel.org, "John W. Linville" <linville@tuxdriver.com>
Subject: Re: Patch inclusion in stable
Date: Thu, 18 Mar 2010 13:17:40 +0100 [thread overview]
Message-ID: <20100318121739.GA2390@dhcp-lab-161.englab.brq.redhat.com> (raw)
In-Reply-To: <1268911953.4382.23.camel@subu>
On Thu, Mar 18, 2010 at 01:32:33PM +0200, Surbhi Palande wrote:
> Hi All,
>
> I had a look at the 2.6.32.10 stable patches. Had a comment on the 31st
> patch in the series:
>
> commit 7ef79e1045213953b87f45cf5993cc9c70c873ec
> Author: Stanislaw Gruszka <sgruszka@redhat.com>
>
> airo: fix setting zero length WEP key
>
> The linux-2.6 source has another patch that adds the following line:
> if (WARN_ON(keylen == 0))
> >> + return -1;
>
> This is added through the commit
> 6510b8917948283005a125c8337d3312a8a0561c. This commit is missing in the
> 2.6.32.10 stable patches. I think it should be a part of stable patches
> too.
keylen == 0 is just bug and should never happen. As we are printing
calltrace in such situation user is informed of a bug. Return from
function in that case is nice, but not strictly necessary.
Cheers
Stanislaw
prev parent reply other threads:[~2010-03-18 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 11:32 Surbhi Palande
2010-03-18 12:17 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100318121739.GA2390@dhcp-lab-161.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=Surbhi.Palande@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®