From: Christian Ehrhardt <lk@c--e.de>
To: linux-kernel@vger.kernel.org, ecryptfs-devel@lists.launchpad.net
Cc: linux-fsdevel@vger.kernel.org
Subject: [PATCH] Fix ecryptfs related OOPs after umount
Date: Fri, 19 Mar 2010 09:39:17 +0100 [thread overview]
Message-ID: <20100319083917.GE16643@lisa.in-ulm.de> (raw)
Hi,
the following patch removes a d_drop in ecryptfs that is bogus IMHO.
This d_drop unhashes a perfectly valid and reachable dentry in the
lower FS. The patch fixes this perfectly reproducible kernel oops:
https://bugzilla.kernel.org/show_bug.cgi?id=10907
It and may or may not be related to this ecryptfs bug:
https://bugs.launchpad.net/ecryptfs/+bug/363734
At least the BUG_ON is on a dentry that should not be unhashed but is.
regards Christian
Signed-off-by: Christian Ehrhardt <lk@c--e.de>
diff --git a/fs/ecryptfs/super.c b/fs/ecryptfs/super.c
index b15a43a..1a037f7 100644
--- a/fs/ecryptfs/super.c
+++ b/fs/ecryptfs/super.c
@@ -85,7 +85,6 @@ static void ecryptfs_destroy_inode(struct inode *inode)
if (lower_dentry->d_inode) {
fput(inode_info->lower_file);
inode_info->lower_file = NULL;
- d_drop(lower_dentry);
}
}
ecryptfs_destroy_crypt_stat(&inode_info->crypt_stat);
reply other threads:[~2010-03-19 8:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100319083917.GE16643@lisa.in-ulm.de \
--to=lk@c--e.de \
--cc=ecryptfs-devel@lists.launchpad.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®