From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Florian Fainelli <florian@openwrt.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Wim Van Sebroeck <wim@iguana.be>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/4 v2] MFD: add support for the RDC321x southbridge
Date: Sat, 20 Mar 2010 12:56:28 +1100 [thread overview]
Message-ID: <20100320125628.6cfcf118.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20100319135209.435131cb.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
Hi Florian,
On Fri, 19 Mar 2010 13:52:09 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Thu, 11 Mar 2010 09:42:09 +0100
> Florian Fainelli <florian@openwrt.org> wrote:
>
> > +static struct pci_device_id rdc321x_sb_table[] = {
> > + { PCI_DEVICE(PCI_VENDOR_ID_RDC, PCI_DEVICE_ID_RDC_R6030) },
> > + {}
> > +};
>
> should be const, methinks.
In fact maybe even
static DEFINE_PCI_DEVICE_TABLE(rdc321x_sb_table) = {
...
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2010-03-20 1:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 8:42 Florian Fainelli
2010-03-19 15:37 ` Samuel Ortiz
2010-03-19 20:52 ` Andrew Morton
2010-03-20 1:56 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100320125628.6cfcf118.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sameo@linux.intel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®