From: Pavel Machek <pavel@ucw.cz>
To: Lars Lindley <lindley@coyote.org>
Cc: gregkh@suse.de, greg@kroah.com, penberg@cs.helsinki.fi,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: sme_api.h Coding style fixes.
Date: Sun, 21 Mar 2010 21:12:21 +0100 [thread overview]
Message-ID: <20100321201221.GI1933@elf.ucw.cz> (raw)
In-Reply-To: <1269190503-12050-1-git-send-email-lindley@coyote.org>
On Sun 2010-03-21 17:55:03, Lars Lindley wrote:
> I fixed the things reported by checkpatch.pl except
> one long line and a __inline.
> I also removed commented away code and versioning comments.
>
> Signed-off-by: Lars Lindley <lindley@coyote.org>
ACK.
> @@ -18,42 +12,42 @@
> #include "localpara.h"
>
> /****************** CONSTANT AND MACRO SECTION ******************************/
> -#define _INLINE __inline
> +#define _INLINE __inline
doing s/_INLINE/__inline/ on whole sources would be nice....
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2010-03-21 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 16:55 Lars Lindley
2010-03-21 20:12 ` Pavel Machek [this message]
2010-03-21 20:25 ` Pekka Enberg
2010-03-21 20:26 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100321201221.GI1933@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®