From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
alan@lxorguk.ukuu.org.uk, mgarski@post.pl,
linux-input@vger.kernel.org, Vojtech Pavlik <vojtech@suse.cz>,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] Route kbd LEDs through the generic LEDs layer (5th version)
Date: Sun, 21 Mar 2010 22:16:53 +0100 [thread overview]
Message-ID: <20100321211653.GS12469@const.famille.thibault.fr> (raw)
In-Reply-To: <20100321210938.GB2057@elf.ucw.cz>
Pavel Machek, le Sun 21 Mar 2010 22:09:38 +0100, a écrit :
> Now, minor comments:
>
> sometimes it uses "numl" (led name), sometimes it uses "numlock"
> trigger name.
Yes, I preferred to stick to the existing names: numl like LED_NUML, and
numlock like VC_NUMLOCK. I don't have any opinion on this however.
> root@amd:/sys/class/leds/input5::numl# echo heartbeat > trigger
>
> did not do the trick on my thinkpad. It still acts as numlock led. Is
> it driven by hw? input5::capsl works as expected.
If it is a laptop, it is likely, depending on the BIOS & such.
On my laptop, doing this works fine.
Samuel
next prev parent reply other threads:[~2010-03-21 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-07 20:02 [PATCH] Route kbd LEDs through the generic LEDs layer (4th version) Samuel Thibault
2010-03-10 13:30 ` [PATCH] Route kbd LEDs through the generic LEDs layer (5th version) Samuel Thibault
2010-03-21 21:09 ` Pavel Machek
2010-03-21 21:16 ` Samuel Thibault [this message]
2010-03-22 8:39 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100321211653.GS12469@const.famille.thibault.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgarski@post.pl \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®