From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754222Ab0CVIzT (ORCPT ); Mon, 22 Mar 2010 04:55:19 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:56524 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753656Ab0CVIzR (ORCPT ); Mon, 22 Mar 2010 04:55:17 -0400 Date: Mon, 22 Mar 2010 09:54:29 +0100 From: Wolfram Sang To: Dmitry Torokhov Cc: kernel-janitors@vger.kernel.org, "Eric W. Biederman" , Greg KH , Benjamin Herrenschmidt , Mike Isely , Mauro Carvalho Chehab , Sujith Thomas , Matthew Garrett , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] device_attributes: add sysfs_attr_init() for dynamic attributes Message-ID: <20100322085429.GA15063@pengutronix.de> References: <1269238878-991-1-git-send-email-w.sang@pengutronix.de> <20100322064027.GG31621@core.coreip.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: <20100322064027.GG31621@core.coreip.homeip.net> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: wsa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 21, 2010 at 11:40:28PM -0700, Dmitry Torokhov wrote: > My standard question - are all of these need to be dynamically > allocated? I have my doubts for a few of them. Still, this would be a more intrusive change than just fixing the BUG appearance, so I'd like to leave that task = for those having the proper setup. Regarding thermal_sys.c, which has two bug reports already, it needs to be dynamic as the attribute name depends on the device. Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --liOOAslEiF7prFVr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkunMEUACgkQD27XaX1/VRsGjQCgteCT6utOHw1aT5jKNRJnqWa2 uqIAn0gXBpowL23wFc6gSgABp3M5T/oZ =eDuH -----END PGP SIGNATURE----- --liOOAslEiF7prFVr--