From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754595Ab0CVLCD (ORCPT ); Mon, 22 Mar 2010 07:02:03 -0400 Received: from legolas.restena.lu ([158.64.1.34]:42870 "EHLO legolas.restena.lu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754506Ab0CVLB7 convert rfc822-to-8bit (ORCPT ); Mon, 22 Mar 2010 07:01:59 -0400 Date: Mon, 22 Mar 2010 12:01:16 +0100 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Jiri Kosina Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Rick L. Vinyard Jr." , Nicu Pavel , Oliver Neukum , Jaya Kumar , Richard Purdie Subject: Re: [PATCH v2 3/6] hid: add backlight support to PicoLCD device Message-ID: <20100322120116.12979762@neptune.home> In-Reply-To: References: <20100320170014.440959a8@neptune.home> <20100320170619.4ae99546@neptune.home> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 March 2010 Jiri Kosina wrote: > On Sat, 20 Mar 2010, Bruno Prémont wrote: > > > Add backlight support to PicoLCD device. > > > > Backlight support depends on backlight class and is only being > > compiled if backlight class has been selected. > > > > Signed-off-by: Bruno Prémont > > --- > > drivers/hid/Kconfig | 2 +- > > drivers/hid/hid-picolcd.c | 134 ++++++++++++++++++++++++++++++++++++++++++++- > > 2 files changed, 134 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > > index a474bcd..5ec3cb7 100644 > > --- a/drivers/hid/Kconfig > > +++ b/drivers/hid/Kconfig > > @@ -243,8 +243,8 @@ config HID_PICOLCD > > - Keypad > > - Switching between Firmware and Flash mode > > - Framebuffer for monochrome 256x64 display > > + - Backlight control (needs CONFIG_BACKLIGHT_CLASS_DEVICE) > > Wouldn't it be better to have Kconfig rules actually resolve the > dependency? > > I don't see any issue with HID_PICOLCD directly selecting > BACKLIGHT_CLASS_DEVICE. Or you can do a separate sub-option for that, if > you really want to avoid the direct dependency of the whole driver. I could select both BACKLIGHT_CLASS_DEVICE and LCD_CLASS_DEVICE (as well as their common parent -- same applies to FB) though for the LEDS_CLASS I would definitely rather go the path of a sub-option, by default the GPO pins operated with the LEDs are not connected to anything. Thanks for the review, Bruno