From: Andi Kleen <andi@firstfloor.org>
To: James Kosin <jkosin@intcomgrp.com>
Cc: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org
Subject: Re: [OT] Style Issues / Concerns
Date: Mon, 22 Mar 2010 21:55:43 +0100 [thread overview]
Message-ID: <20100322205543.GB20695@one.firstfloor.org> (raw)
In-Reply-To: <4BA7D433.1050109@intcomgrp.com>
On Mon, Mar 22, 2010 at 04:33:55PM -0400, James Kosin wrote:
> On 3/22/2010 4:13 PM, Andi Kleen wrote:
> > James Kosin <jkosin@intcomgrp.com> writes:
> >
> >> Before everyone jumps in at once, this is a simple example that will
> >> produce a compiler error about the misplaced else. However if there are
> >> many if statements above this that may allow the else to be paired up
> >> with it then the code will compile and there will be a serious and very
> >> difficult bug in the code that will take days or months to find.
> >>
> > Modern editors with auto indent mode makes it actually very easy
> > to find such bugs.
> >
> > Also checkpatch.pl checks for it now I believe.
> >
> Thanks for the speedy reply.
>
> Does this mean developers need to install X or some graphical
> environment now to develop the kernel?
Modern was perhaps the wrong word. emacs, vim support that.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2010-03-22 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 20:02 James Kosin
2010-03-22 20:13 ` Andi Kleen
2010-03-22 20:33 ` James Kosin
2010-03-22 20:55 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322205543.GB20695@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=jkosin@intcomgrp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®