From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756601Ab0CVVva (ORCPT ); Mon, 22 Mar 2010 17:51:30 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:46660 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755575Ab0CVVvZ (ORCPT ); Mon, 22 Mar 2010 17:51:25 -0400 Date: Mon, 22 Mar 2010 21:51:18 +0000 From: Mark Brown To: Jean Delvare Cc: Hans Verkuil , Wolfram Sang , kernel-janitors@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org Message-ID: <20100322215118.GC17533@sirena.org.uk> References: <1269094385-16114-1-git-send-email-w.sang@pengutronix.de> <20100321144655.4747fd2a@hyperion.delvare> <20100321141417.GA19626@opensource.wolfsonmicro.com> <201003211709.56319.hverkuil@xs4all.nl> <20100322213358.31e50b3c@hyperion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100322213358.31e50b3c@hyperion.delvare> X-Cookie: You will soon forget this. User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: 82.41.240.126 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 12/24] media/video: fix dangling pointers X-SA-Exim-Version: 4.2.1 (built Wed, 25 Jun 2008 17:14:11 +0000) X-SA-Exim-Scanned: Yes (on cassiel.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 22, 2010 at 09:33:58PM +0100, Jean Delvare wrote: > On Sun, 21 Mar 2010 17:09:56 +0100, Hans Verkuil wrote: > > On Sunday 21 March 2010 15:14:17 Mark Brown wrote: > > > I agree with this. There are also some use cases where the device data > > > is actually static (eg, a generic description of the device or a > > > reference to some other shared resource rather than per device allocated > > > data). > From a technical perspective, there is little rationale to have the > client data pointed to static data. If you could reach it from probe(), > it has to be a global, and if it is a global, you can reach it again > directly from the rest of your code. The use case I can think of there is bus type specific stuff for devices that support multiple buses.