From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754189Ab0CWFsu (ORCPT ); Tue, 23 Mar 2010 01:48:50 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51270 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751755Ab0CWFss (ORCPT ); Tue, 23 Mar 2010 01:48:48 -0400 Date: Mon, 22 Mar 2010 22:47:33 -0400 From: Andrew Morton To: Ben Hutchings Cc: Jesse Barnes , David Woodhouse , linux-pci@vger.kernel.org, LKML , linux-parisc@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH 2/4] panic: Allow taint flag for warnings to be changed from TAINT_WARN Message-Id: <20100322224733.9cf93a0a.akpm@linux-foundation.org> In-Reply-To: <1269126340.18314.115.camel@localhost> References: <1269126097.18314.111.camel@localhost> <1269126340.18314.115.camel@localhost> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 20 Mar 2010 23:05:40 +0000 Ben Hutchings wrote: > WARN() is used in some places to report firmware or hardware bugs that > are then worked-around. These bugs do not affect the stability of the > kernel and should not set the usual TAINT_WARN flag. To allow for > this, add WARN_TAINT() and WARN_TAINT_ONCE() macros that take a taint > flag as argument. > > Architectures that implement warnings using trap instructions instead > of calls to warn_slowpath_*() must now implement __WARN_TAINT(taint) > instead of __WARN(). When you say they "must now implement", I assume that you mean that they _do_ now implement, and that no additional architecture work is needed. > The architecture-specific changes here are untested and need to be > reviewed by architecture maintainers. That would be nice.