From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754854Ab0CXGr5 (ORCPT ); Wed, 24 Mar 2010 02:47:57 -0400 Received: from symlink.to.noone.org ([85.10.207.172]:57177 "EHLO sym.noone.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752874Ab0CXGrz (ORCPT ); Wed, 24 Mar 2010 02:47:55 -0400 Date: Wed, 24 Mar 2010 07:47:47 +0100 From: Tobias Klauser To: Andrew Morton Cc: linux-serial@vger.kernel.org, gregkh@suse.de, nios2-dev@sopc.et.ntust.edu.tw, linux-kernel@vger.kernel.org, Alan Cox Subject: Re: [PATCHv3 2/2] serial: Add driver for the Altera UART Message-ID: <20100324064747.GP21818@distanz.ch> References: <15dc056891fb785001073bab4f9a0d0f3bf99af1.1267807169.git.klto@zhaw.ch> <20100323145459.9894b1e6.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100323145459.9894b1e6.akpm@linux-foundation.org> X-Editor: Vi IMproved 7.1 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2010-03-23 at 22:54:59 +0100, Andrew Morton wrote: > On Fri, 5 Mar 2010 17:52:23 +0100 > Tobias Klauser wrote: > > > + sigs |= (altera_uart_getppdcd(port->line) ? TIOCM_CD : 0); > > + sigs |= (altera_uart_getppdtr(port->line) ? TIOCM_DTR : 0); > > We seem to be missing a few things here. > > drivers/serial/altera_uart.c: In function 'altera_uart_get_mctrl': > drivers/serial/altera_uart.c:100: error: implicit declaration of function 'altera_uart_getppdcd' > drivers/serial/altera_uart.c:101: error: implicit declaration of function 'altera_uart_getppdtr' > drivers/serial/altera_uart.c: In function 'altera_uart_set_mctrl': > drivers/serial/altera_uart.c:114: error: implicit declaration of function 'altera_uart_setppdtr' These should usually be declared in a board specific header. There were compatibility macros in altera_uart.c which defined them to NOPs in case the board header did not properly define them. But I remove them as per request by Alan Cox (Message-ID: 20100301181920.3952c3e7@lxorguk.ukuu.org.uk). Should we add them again (maybe to altera_uart.h)? Or would it be better to define a config symbol which is set in the board specific Kconfig and altera_uart depends on it? Thanks Tobias