mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Tilman Schmidt <tilman@imap.cc>
Cc: Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org, apw@canonical.com
Subject: Re: [PATCH] checkpatch: Add check for too short Kconfig descriptions
Date: Wed, 24 Mar 2010 14:39:39 +0100	[thread overview]
Message-ID: <20100324133939.GF20695@one.firstfloor.org> (raw)
In-Reply-To: <4BAA0598.9000906@imap.cc>

> - -+			WARN("please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($length < 4);
> ++			WARN("Less than four lines of help text -- consider adding more detail\n" . $herecurr) if ($length < 4);

I don't want to give the number, because that just tempts people
to "game" the rule. Ideally they should just use as many lines
as needed, not just four.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2010-03-24 13:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-20  2:32 Andi Kleen
2010-03-20 13:31 ` Tilman Schmidt
2010-03-20 14:07   ` Andi Kleen
2010-03-20 17:24     ` Tilman Schmidt
2010-03-20 18:03       ` Andi Kleen
2010-03-24 12:29         ` Tilman Schmidt
2010-03-24 13:39           ` Andi Kleen [this message]
2010-03-24 22:31             ` Tilman Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100324133939.GF20695@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tilman@imap.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®