From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754760Ab0CYUNP (ORCPT ); Thu, 25 Mar 2010 16:13:15 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:51284 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754394Ab0CYUNN (ORCPT ); Thu, 25 Mar 2010 16:13:13 -0400 From: "Rafael J. Wysocki" To: Mark Brown Subject: Re: [PATCH] i2c: Fix bus-level power management callbacks Date: Thu, 25 Mar 2010 21:16:23 +0100 User-Agent: KMail/1.12.4 (Linux/2.6.34-rc2-rjw; KDE/4.3.5; x86_64; ; ) Cc: Jean Delvare , linux-pm@lists.linux-foundation.org, Linux I2C , Alan Stern , LKML References: <201003132204.30905.rjw@sisk.pl> <20100325095720.0b115056@hyperion.delvare> <20100325092802.GA27729@rakim.wolfsonmicro.main> In-Reply-To: <20100325092802.GA27729@rakim.wolfsonmicro.main> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201003252116.23171.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 25 March 2010, Mark Brown wrote: > On Thu, Mar 25, 2010 at 09:57:20AM +0100, Jean Delvare wrote: > > > Mark, you contributed the initial runtime PM support for the i2c > > subsystem, I thought you would have comments on Rafael's > > reimplementation? > > Yeah, see below... > > > > drivers/i2c/i2c-core.c | 168 ++++++++++++++++++++++++++------------------- > > > include/linux/pm_runtime.h | 7 + > > > I am a little surprised to see changes to a generic header file here, > > how is the i2c subsystem so special that we have needs other subsystems > > did not? > > Very few subsystems actually support runtime PM thus far - I think it's > more the case that I2C is an early user than anything else. That's the case indeed. > > Apart from the above, the code looks sane to me, but then again I don't > > know a thing about power management. I'll keep this patch in my i2c > > tree, scheduled for merge in 2.6.35. If there are any updates, please > > send them over, either as a new patch or as incremental changes which I > > will merge myself. > > I'm in a similar position - the code looks fine except I'm not 100% sure > I follow all the possible ifdefs and I've never actually used hibernate > (s2disk isn't supported on ARM) but for what it's worth: > > Acked-by: Mark Brown Thanks! Rafael