From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753024Ab0CZJ4x (ORCPT ); Fri, 26 Mar 2010 05:56:53 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:54008 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752622Ab0CZJ4w (ORCPT ); Fri, 26 Mar 2010 05:56:52 -0400 Date: Fri, 26 Mar 2010 09:59:29 +0000 From: Alan Cox To: Ingo Molnar Cc: Thomas Gleixner , Nicolas Pitre , Linus Torvalds , LKML , linux-arch@vger.kernel.org, Andrew Morton , Peter Zijlstra , Andi Kleen , David Miller , Greg Kroah-Hartman , Arnaldo Carvalho de Melo , Russell King Subject: Re: [patch 0/2] Run interrupt handlers always with interrupts disabled Message-ID: <20100326095929.063c5f63@lxorguk.ukuu.org.uk> In-Reply-To: <20100326092023.GH27394@elte.hu> References: <20100326000325.917127328@linutronix.de> <20100326081457.GA23570@flint.arm.linux.org.uk> <20100326092023.GH27394@elte.hu> X-Mailer: Claws Mail 3.7.4 (GTK+ 2.18.6; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > As long as it's rare (which it is) i dont see a problem: you can enable > interrupts in the handler by using local_irq_enable(), like the IDE PIO > drivers do. That way it's documented a bit better as well, because it shows > the precise source of the latency, with a big comment explaining it, etc. I don't think it's as rare as you think particularly in embedded, and the moment you start explicitly using local_irq_enable() you've simply moved the underlying problem back and made it far harder to grep for. Alan