From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Travis <travis@sgi.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.34-rc1: pci_register_set_vga_state section mismatch
Date: Fri, 26 Mar 2010 16:31:28 -0700 [thread overview]
Message-ID: <20100326163128.2d4ca1a1@jbarnes-piketon> (raw)
In-Reply-To: <4BACB9DD.6000103@s5r6.in-berlin.de>
On Fri, 26 Mar 2010 14:42:53 +0100
Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> Stefan Richter wrote:
> >> WARNING: drivers/pci/built-in.o(__ksymtab+0x320): Section mismatch in reference from the variable __ksymtab_pci_register_set_vga_state to the function .init.text:pci_register_set_vga_state()
> >> The symbol pci_register_set_vga_state is exported and annotated __init
> >> Fix this by removing the __init annotation of pci_register_set_vga_state or drop the export.
> >
> > This is obviously introduced by commit
> > 95a8b6efc5d07103583f706c8a5889437d537939
> > pci: Update pci_set_vga_state() to call arch functions
>
> PS:
> There is only a single user of this symbol in the mainline at the
> moment, arch/x86/kernel/apic/x2apic_uv_x.c, controlled by
> arch/x86/Kconfig:config X86_UV, which allows only static linking.
> I.e. the warning is a false positive for now. But given how small
> pci_register_set_vga_state() is, it appears appropriate to drop the
> __init annotation.
I'm just sending out a fix to remove the export now.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2010-03-26 23:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 13:32 Stefan Richter
2010-03-26 13:42 ` Stefan Richter
2010-03-26 23:31 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100326163128.2d4ca1a1@jbarnes-piketon \
--to=jbarnes@virtuousgeek.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®