mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@sous-sol.org>
To: Henrik Kretzschmar <henne@nachtwindheim.de>
Cc: jbarnes@virtuousgeek.org, David.Woodhouse@intel.com,
	len.brown@intel.com, chrisw@sous-sol.org,
	suresh.b.siddha@intel.com, mingo@elte.hu, yu.zhao@intel.com,
	fenghua.yu@intel.com, weidong@intel.com,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	iommu@lists.linux-foundation.org
Subject: Re: [PATCH] dmar: section mismatch cleanup
Date: Fri, 26 Mar 2010 14:58:04 -0700	[thread overview]
Message-ID: <20100326215804.GF29241@sequoia.sous-sol.org> (raw)
In-Reply-To: <1269633200-19970-1-git-send-email-henne@nachtwindheim.de>

* Henrik Kretzschmar (henne@nachtwindheim.de) wrote:
> This patch fixes a section mismatch.
> 
> WARNING: drivers/pci/built-in.o(.text+0x182f5): Section mismatch in
> reference from the function dmar_ir_support() to the variable
> .init.data:acpi_slot_detected
> The function dmar_ir_support() references
> the variable __initdata acpi_slot_detected.
> This is often because dmar_ir_support lacks a __initdata
> annotation or the annotation of acpi_slot_detected is wrong.
> 
> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>

Acked-by: Chris Wright <chrisw@sous-sol.org>

> -int dmar_ir_support(void)
> +int __init dmar_ir_support(void)

> -extern int dmar_ir_support(void);
> +extern int dmar_ir_support(void) __init;

Nit, but prerfer to see:

-extern int dmar_ir_support(void);
+extern int __init dmar_ir_support(void);

thanks,
-chris

      reply	other threads:[~2010-03-26 21:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-26 19:53 Henrik Kretzschmar
2010-03-26 21:58 ` Chris Wright [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100326215804.GF29241@sequoia.sous-sol.org \
    --to=chrisw@sous-sol.org \
    --cc=David.Woodhouse@intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=henne@nachtwindheim.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=suresh.b.siddha@intel.com \
    --cc=weidong@intel.com \
    --cc=yu.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome