mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: pavan_savoy@ti.com
Cc: marcel@holtmann.org, gregkh@suse.de,
	linux-kernel@vger.kernel.org, pavan_savoy@yahoo.co.in
Subject: Re: [PATCH] drivers:staging: sources for HCI LL PM protocol
Date: Tue, 30 Mar 2010 12:24:40 +0100	[thread overview]
Message-ID: <20100330122440.1e3d8bf1@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1269559223-4043-5-git-send-email-pavan_savoy@ti.com>


> +static struct ll_struct_s *ll;

More magic globals. I think this more than anything else demonstrates why
you need some kind of proper per device context passed around


  parent reply	other threads:[~2010-03-30 11:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-25 23:20 [v4] New ldisc for WiLink7.0 pavan_savoy
2010-03-25 23:20 ` [PATCH] serial: TTY: new ldiscs for staging pavan_savoy
2010-03-25 23:20   ` [PATCH] drivers:staging: sources for ST core pavan_savoy
2010-03-25 23:20     ` [PATCH] drivers:staging: sources for Init manager module pavan_savoy
2010-03-25 23:20       ` [PATCH] drivers:staging: sources for HCI LL PM protocol pavan_savoy
2010-03-25 23:20         ` [PATCH] drivers:staging: sources for ST header file pavan_savoy
2010-03-25 23:20           ` [PATCH] drivers:staging: Kconfig, Makefile for TI's ST ldisc pavan_savoy
2010-03-25 23:20             ` [PATCH] Documentation:staging: add TODO and ABI to ti-st pavan_savoy
2010-03-25 23:20               ` [PATCH] bluetooth: BT driver using ST for TI combo devices pavan_savoy
2010-03-30 11:24         ` Alan Cox [this message]
2010-03-30 15:03           ` [PATCH] drivers:staging: sources for HCI LL PM protocol Pavan Savoy
2010-03-30 18:33             ` Alan Cox
2010-03-30 11:22     ` [PATCH] drivers:staging: sources for ST core Alan Cox
2010-03-30 15:53       ` Pavan Savoy
2010-03-30 20:38         ` Greg KH
2010-03-30 21:05           ` Pavan Savoy
2010-03-30 21:47             ` Greg KH
2010-03-31  2:24             ` Joe Perches
2010-03-25 23:30   ` [PATCH] serial: TTY: new ldiscs for staging Alan Cox
2010-03-26 15:08     ` Pavan Savoy
2010-03-28  4:58 ` [v4] New ldisc for WiLink7.0 Greg KH
2010-04-08 18:16 pavan_savoy
2010-04-08 18:16 ` [PATCH] serial: TTY: new ldiscs for staging pavan_savoy
2010-04-08 18:16   ` [PATCH] drivers:staging: sources for ST core pavan_savoy
2010-04-08 18:16     ` [PATCH] drivers:staging: sources for Init manager module pavan_savoy
2010-04-08 18:16       ` [PATCH] drivers:staging: sources for HCI LL PM protocol pavan_savoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100330122440.1e3d8bf1@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=pavan_savoy@ti.com \
    --cc=pavan_savoy@yahoo.co.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®