Re: [PATCH] acpi: sleep: fixed a brace coding style issue

[Pavel Machek <pavel@ucw.cz>]

On Tue 2010-03-09 23:56:20, Bruno Bigras wrote:
> Fix a coding style issue.
> 
> Signed-off-by: Bruno Bigras <bigras.bruno@gmail.com>


While I'm not fan of {}s, this is really excessive.

...especially in a code that uses u32 to pass enums, and opencodes
typecasts.

								Pavel
> ---
>  drivers/acpi/sleep.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> index 3bde594..fc8343f 100644
> --- a/drivers/acpi/sleep.c
> +++ b/drivers/acpi/sleep.c
> @@ -62,9 +62,9 @@ static int acpi_sleep_prepare(u32 acpi_state)
>  #ifdef CONFIG_ACPI_SLEEP
>  	/* do we have a wakeup address for S2 and S3? */
>  	if (acpi_state == ACPI_STATE_S3) {
> -		if (!acpi_wakeup_address) {
> +		if (!acpi_wakeup_address)
>  			return -EFAULT;
> -		}
> +
>  		acpi_set_firmware_waking_vector(
>  				(acpi_physical_address)acpi_wakeup_address);
>  

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html