From: Arnd Bergmann <arnd@arndb.de>
To: Alessio Igor Bogani <abogani@texware.it>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan Blunck <jblunck@suse.de>
Subject: Re: [PATCH] USB: Remove BKL from remount() function in usbfs
Date: Wed, 31 Mar 2010 15:54:37 +0100 [thread overview]
Message-ID: <201003311654.38020.arnd@arndb.de> (raw)
In-Reply-To: <1270044578-4291-1-git-send-email-abogani@texware.it>
On Wednesday 31 March 2010, Alessio Igor Bogani wrote:
>
> The BKL was used into remount_fs pointed function for serialized access to
> super_block from the others super_operations functions.
>
> The function update_sb(), invoked by remount(), seems already well serialized
> with &root->d_inode->i_mutex. Moreover don't seems there are others
> super_operations functions in USB core for usbfs that should access to
> super_block in a way which require BKL.
There is a patch from Jan Blunck pending in the bkl-removal tree that pushes
down the BKL into usbfs_fill_super. Can you confirm that this BKL usage does
not interfere with the one you just removed, and that it can go the same way?
Arnd
next prev parent reply other threads:[~2010-03-31 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 14:09 Alessio Igor Bogani
2010-03-31 14:54 ` Arnd Bergmann [this message]
2010-03-31 17:21 ` Alessio Igor Bogani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003311654.38020.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=abogani@texware.it \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=jblunck@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®