From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758174Ab0DBC0w (ORCPT ); Thu, 1 Apr 2010 22:26:52 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:59592 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756044Ab0DBC0s (ORCPT ); Thu, 1 Apr 2010 22:26:48 -0400 Date: Thu, 01 Apr 2010 19:26:48 -0700 (PDT) Message-Id: <20100401.192648.185498218.davem@davemloft.net> To: mst@redhat.com Cc: rusty@rustcorp.com.au, jpirko@redhat.com, xma@us.ibm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] virtio-net: move sg off stack From: David Miller In-Reply-To: <20100331124156.GA4598@redhat.com> References: <20100331.031636.04083770.davem@davemloft.net> <20100331124156.GA4598@redhat.com> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Michael S. Tsirkin" Date: Wed, 31 Mar 2010 15:41:58 +0300 > Move sg structure off stack and into virtnet_info structure. > This helps remove extra sg_init_table calls as well as reduce > stack usage. > > Signed-off-by: Michael S. Tsirkin > --- > > Compile-tested only for now. > Shirley, Rusty Russell, does this fix CONFIG_DEBUG_SG=y for you? I'll apply this once I see some ACKs on testing. Thanks.