From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757899Ab0DAAvJ (ORCPT ); Wed, 31 Mar 2010 20:51:09 -0400 Received: from chilli.pcug.org.au ([203.10.76.44]:43772 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757388Ab0DAAvH (ORCPT ); Wed, 31 Mar 2010 20:51:07 -0400 Date: Thu, 1 Apr 2010 11:50:59 +1100 From: Stephen Rothwell To: Steve French , Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Suresh Jayaraman Subject: linux-next: build warning after merge of the cifs tree Message-Id: <20100401115059.d0bdb1bd.sfr@canb.auug.org.au> X-Mailer: Sylpheed 3.0.1 (GTK+ 2.18.9; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Thu__1_Apr_2010_11_50_59_+1100_tLGndIcf21WS7aeD" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Signature=_Thu__1_Apr_2010_11_50_59_+1100_tLGndIcf21WS7aeD Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Steve, After merging the cifs tree, today's linux-next build (x86_64 allmodconfig) produced this warning: fs/cifs/cifssmb.c: In function 'CIFSSMBWrite': fs/cifs/cifssmb.c:1516: warning: suggest explicit braces to avoid ambiguous= 'else' Introduced by commit 5702f749ee6645f70412cfe6408503a735366ffe ("cifs: initialize nbytes at the beginning of CIFSSMBWrite()"). The cFYI() macro that is invoked in the (unbraced) if clause contains an if statement ... so this warning actually indicates a bug. Those debugging macros look like a real mess ... --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ --Signature=_Thu__1_Apr_2010_11_50_59_+1100_tLGndIcf21WS7aeD Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkuz7fMACgkQjjKRsyhoI8wK8gCfQ6hlYEaHt9CstI046s55rUCe jAgAoLETu8apz1owpgeaZJJAGrBLtBG3 =UgKh -----END PGP SIGNATURE----- --Signature=_Thu__1_Apr_2010_11_50_59_+1100_tLGndIcf21WS7aeD--