mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tejun Heo <tj@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	lkml <linux-kernel@vger.kernel.org>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH ide#master] ide: clean up timed out request handling
Date: Mon, 5 Apr 2010 18:13:13 +0800	[thread overview]
Message-ID: <20100405101313.GA17322@gondor.apana.org.au> (raw)
In-Reply-To: <4BB9AAB7.3020209@kernel.org>

On Mon, Apr 05, 2010 at 06:17:43PM +0900, Tejun Heo wrote:
> 8f6205cd572fece673da0255d74843680f67f879 introduced a bug where a
> timed out DMA request is never requeued and lost.
> 6072f7491f5ef391a575e18a1165e72a3eef1601 fixed this by making
> ide_dma_timeout_retry() requeue the request itself.  While the fix is
> correct, it makes DMA and non-DMA paths asymmetric regarding how the
> in flight request is requeued.
> 
> As long as hwif->rq is set, the IDE driver is assuming ownership of
> the request and the request should either be completed or requeued
> when clearing hwif->rq.  In the timeout path, the ide driver holds
> onto the request as long as the recovery action (ie. reset) is in
> progress and clears it after the state machine is stopped (ide_stopped
> return), so the existing requeueing logic is correct.  The bug
> occurred because ide_dma_timeout_retry() explicitly clears hwif->rq
> without requeueing it.
> 
> ide_dma_timeout_retry() is called only by ide_timer_expiry() and
> returns ide_started only when ide_error() would return it - ie. after
> reset state machine has started in which case the state machine will
> eventually end up executing the ide_stopped path in ide_timer_expiry()
> after reset protocol is complete.  So, there is no need to clear
> hwif->rq from ide_dma_timeout_retry().  ide_timer_expiry() will handle
> it the same way as PIO timeout path.
> 
> Kill hwif->rq clearing and requeueing from ide_dma_timeout_retry() and
> let ide_timer_expiry() deal with it.  The end result should remain the
> same.
> 
> grepping shows ide_dma_timeout_retry() is the only site which clears
> hwif->rq without taking care of the request, so there shouldn't be
> similar fallouts.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> Herbert, can you please test this survives your test case?

I'll put it on my test machine.

However, as this bug triggers rarely (it's a race condition between
qemu and ide), I don't expect a negative result any time soon.

In any case, your patch looks good to me.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2010-04-05 10:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-05  9:17 Tejun Heo
2010-04-05 10:13 ` Herbert Xu [this message]
2010-04-08  5:02   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100405101313.GA17322@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=bzolnier@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®