From: Andrew Morton <akpm@linux-foundation.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH -mm 2/5] asm-generic: add NEED_SG_DMA_LENGTH to define sg_dma_len()
Date: Mon, 5 Apr 2010 16:35:41 -0700 [thread overview]
Message-ID: <20100405163541.aa10c605.akpm@linux-foundation.org> (raw)
In-Reply-To: <1270391153-17519-3-git-send-email-fujita.tomonori@lab.ntt.co.jp>
On Sun, 4 Apr 2010 23:25:50 +0900
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> There are only two ways to define sg_dma_len(); use sg->dma_length or
> sg->length. This patch introduces NEED_SG_DMA_LENGTH that enables
> architectures to choose sg->dma_length or sg->length.
i386 allnoconfig:
arch/x86/kernel/pci-nommu.c: In function 'nommu_map_sg':
arch/x86/kernel/pci-nommu.c:71: error: 'struct scatterlist' has no member named 'dma_length'
So I enabled NEED_SG_DMA_LENGTH on x86_32 as well. It compiles...
--- a/arch/x86/Kconfig~asm-generic-add-need_sg_dma_length-to-define-sg_dma_len-fix
+++ a/arch/x86/Kconfig
@@ -103,7 +103,7 @@ config NEED_DMA_MAP_STATE
def_bool (X86_64 || DMAR || DMA_API_DEBUG)
config NEED_SG_DMA_LENGTH
- def_bool X86_64
+ def_bool y
config GENERIC_ISA_DMA
def_bool y
diff -puN include/asm-generic/scatterlist.h~asm-generic-add-need_sg_dma_length-to-define-sg_dma_len-fix include/asm-generic/scatterlist.h
_
next prev parent reply other threads:[~2010-04-05 23:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-04 14:25 [PATCH -mm 0/5] use asm-generic/scatterlist.h on every architecture FUJITA Tomonori
2010-04-04 14:25 ` [PATCH -mm 1/5] asm-generic: remove ISA_DMA_THRESHOLD in scatterlist.h FUJITA Tomonori
2010-04-04 14:25 ` [PATCH -mm 2/5] asm-generic: add NEED_SG_DMA_LENGTH to define sg_dma_len() FUJITA Tomonori
2010-04-05 23:35 ` Andrew Morton [this message]
2010-04-05 23:46 ` FUJITA Tomonori
2010-04-06 0:05 ` FUJITA Tomonori
2010-04-04 14:25 ` [PATCH -mm 3/5] powerpc: use asm-generic/scatterlist.h FUJITA Tomonori
2010-04-04 14:25 ` [PATCH -mm 4/5] arm: " FUJITA Tomonori
2010-04-04 14:25 ` [PATCH -mm 5/5] alpha: " FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100405163541.aa10c605.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®