From: David Miller <davem@davemloft.net>
To: peterz@infradead.org
Cc: fweisbec@gmail.com, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@elte.hu, acme@redhat.com,
paulus@samba.org
Subject: Re: [RFC][PATCH] lockdep: WARN about local_irq_{en,dis}able in NMI context
Date: Tue, 06 Apr 2010 04:22:35 -0700 (PDT) [thread overview]
Message-ID: <20100406.042235.133749467.davem@davemloft.net> (raw)
In-Reply-To: <1270552819.1595.63.camel@laptop>
From: Peter Zijlstra <peterz@infradead.org>
Date: Tue, 06 Apr 2010 13:20:19 +0200
> On Tue, 2010-04-06 at 04:13 -0700, David Miller wrote:
>> From: Peter Zijlstra <peterz@infradead.org>
>> Date: Tue, 06 Apr 2010 13:12:01 +0200
>>
>> > One thing we can do is make the code WARN about this, how about
>> > something like the below
>>
>> It's going to warn every bootup in cpu_clock() on x86.
>
> *sigh*, yes, we could hack around that I suppose.. it would be nice to
> automate this check though, I bet you don't fancy tracking down more
> such splats than you have to.
>
> You could of course insert the debug code into your arch routines but
> that would limit the coverage checks to whatever you happen to run.
Yes, f.e. you could add local_irq_*_nmi() or similar that don't
complain when called inside of an NMI.
I would certainly welcome this debugging facility, for sure!
It would have saved me two days of work this time, in fact.
next prev parent reply other threads:[~2010-04-06 11:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-04 12:18 Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Frederic Weisbecker
2010-04-04 12:21 ` Frederic Weisbecker
2010-04-05 1:00 ` David Miller
2010-04-05 6:57 ` Frederic Weisbecker
2010-04-05 19:22 ` David Miller
2010-04-05 19:40 ` Frederic Weisbecker
2010-04-05 20:46 ` David Miller
2010-04-06 2:15 ` David Miller
2010-04-06 13:41 ` Steven Rostedt
2010-04-06 17:46 ` David Miller
2010-04-06 18:15 ` Steven Rostedt
2010-04-06 21:17 ` David Miller
2010-04-06 9:50 ` David Miller
2010-04-06 10:19 ` Frederic Weisbecker
2010-04-06 10:28 ` David Miller
2010-04-06 11:12 ` [RFC][PATCH] lockdep: WARN about local_irq_{en,dis}able in NMI context Peter Zijlstra
2010-04-06 11:13 ` David Miller
2010-04-06 11:20 ` Peter Zijlstra
2010-04-06 11:22 ` David Miller [this message]
2010-04-06 11:38 ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Frederic Weisbecker
2010-04-06 11:51 ` Peter Zijlstra
2010-04-06 12:54 ` Mike Galbraith
2010-04-06 12:57 ` Peter Zijlstra
2010-04-06 18:04 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100406.042235.133749467.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®