From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Yinghai <yinghai.lu@oracle.com>
Cc: Liang Li <liang.li@windriver.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Rusty Russell <rusty@rustcorp.com.au>,
akpm@linux-foundation.org, hpa@zytor.com, mingo@elte.hu,
tglx@linutronix.de, wangchen@cn.fujitsu.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [LKML] Re: + x86-fix-handling-of-the-reservetop-boot-option.patch added to -mm tree
Date: Thu, 8 Apr 2010 14:38:06 -0400 [thread overview]
Message-ID: <20100408183806.GA30940@phenom.dumpdata.com> (raw)
In-Reply-To: <4BBE1A6A.60500@oracle.com>
On Thu, Apr 08, 2010 at 11:03:22AM -0700, Yinghai wrote:
> On 04/08/2010 10:12 AM, Jeremy Fitzhardinge wrote:
> > On 04/08/2010 01:58 AM, Liang Li wrote:
> >>>
> >> When linux as vmi/xen/lguest guest OS, kernel call reserve_top_address
> >> before start_kernel. It is far before the start_kernel hence far before
> >> setup_arch->early_ioremap_init. So it is unsafe to place
> >> fixup_early_ioremap inside reserve_top_address. So I think the patch
> >> should be:
> >>
> >
> > Yes indeed. That looks better.
> >
> > Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
I've also tested it today as PV Xen guest:
Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
next prev parent reply other threads:[~2010-04-08 18:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201004072200.o37M0d19009878@imap1.linux-foundation.org>
2010-04-07 23:52 ` Yinghai
2010-04-08 1:05 ` Liang Li
2010-04-08 1:13 ` Yinghai
2010-04-08 1:53 ` Liang Li
2010-04-08 2:18 ` Liang Li
2010-04-08 4:30 ` Yinghai
2010-04-08 4:59 ` Liang Li
2010-04-08 6:57 ` Yinghai
2010-04-08 8:58 ` Liang Li
2010-04-08 17:12 ` Jeremy Fitzhardinge
2010-04-08 18:03 ` Yinghai
2010-04-08 18:38 ` Konrad Rzeszutek Wilk [this message]
2010-04-09 0:28 ` [LKML] " Liang Li
2010-04-08 17:10 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408183806.GA30940@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=liang.li@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=wangchen@cn.fujitsu.com \
--cc=yinghai.lu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome