From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Wu Fengguang <fengguang.wu@intel.com>,
Andi Kleen <andi@firstfloor.org>, Greg KH <greg@kroah.com>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
stable@kernel.org
Subject: Re: [PATCH] Revert "memory-hotplug: add 0x prefix to HEX block_size_bytes"
Date: Thu, 8 Apr 2010 23:29:18 +0200 [thread overview]
Message-ID: <20100408212918.GA2716@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20100408153745.GA4213@hack>
On Thu, Apr 08, 2010 at 11:41:24PM +0800, Américo Wang wrote:
> On Thu, Apr 08, 2010 at 05:10:06PM +0200, Heiko Carstens wrote:
> >From: Heiko Carstens <heiko.carstens@de.ibm.com>
> >
> >Revert ba168fc37dea145deeb8fa9e7e71c748d2e00d74 "memory-hotplug: add 0x prefix
> >to HEX block_size_bytes" since it changes the user space visible sysfs interface
> >/sys/devices/system/memory/block_size_bytes.
> >The change breaks existing user space applications which rely on the fact that
> >the output does not contain the "0x" prefix.
>
> Odd.
>
> Which application relies on this? Isn't the application which should
> be fixed?? It should use something like strtoul() which doesn't
> rely on '0x' prefix.
Ok, consider it the other way round: your application is doing strtoul()
with a base of 0 (since you rely on the 0x prefix) and for no good reason
it doesn't work on older kernels.
I really can't see a reason for adding additional pitfalls by _changing_
a long existing user space interface.
next prev parent reply other threads:[~2010-04-08 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 15:10 Heiko Carstens
2010-04-08 15:41 ` Américo Wang
2010-04-08 21:29 ` Heiko Carstens [this message]
2010-04-09 1:42 ` Wu Fengguang
2010-04-09 8:31 ` KOSAKI Motohiro
2010-04-12 5:41 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408212918.GA2716@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®