From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753045Ab0DKVnM (ORCPT ); Sun, 11 Apr 2010 17:43:12 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:42363 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752862Ab0DKVnK (ORCPT ); Sun, 11 Apr 2010 17:43:10 -0400 Date: Sun, 11 Apr 2010 14:43:13 -0700 (PDT) Message-Id: <20100411.144313.71127091.davem@davemloft.net> To: herbert@gondor.hengli.com.au Cc: yinghai@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, torvalds@linux-foundation.org Subject: Re: ssh server etc doesn't work anymore with net-2.6 From: David Miller In-Reply-To: <20100411120403.GA20565@gondor.apana.org.au> References: <20100411100902.GA20141@gondor.apana.org.au> <20100411120403.GA20565@gondor.apana.org.au> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Herbert Xu Date: Sun, 11 Apr 2010 20:04:03 +0800 > Herbert Xu wrote: >> >> After looking at the actual net-2.6 tree I see that it is actually >> CHECKSUM_PARTIAL that caused this breakage. >> >> The fact that when this was first implemented we didn't use hw >> checksums on dataless packets might not have been an oversight >> after all. > > Looks like I was too quick to blame the hardware, the synack > code can't handle CHECKSUM_PARTIAL so this is probably the real > cause. > > I will send patches to fix this. Thanks a lot for figuring this out. I'll put my original patch (with fixed commit log message!) and your fixes into net-next-2.6