From: Jan Blunck <jblunck@suse.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Linux-Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 04/12] frv: remove "struct file *" argument from sysctl ->proc_handler
Date: Mon, 12 Apr 2010 10:11:00 +0200 [thread overview]
Message-ID: <20100412081100.GZ10776@bolzano.suse.de> (raw)
In-Reply-To: <u2xb6fcc0a1004090923h261c099fpc40b3c289e981b28@mail.gmail.com>
On Fri, Apr 09, Alexey Dobriyan wrote:
> On Fri, Apr 9, 2010 at 5:00 PM, Jan Blunck <jblunck@suse.de> wrote:
> > Seems that Alexey Dobriyan missed this usage of the file argument when
> > removing it from ->proc_handler in commit 8d65af789f3e2cf4cfbdbf71a0f7a61ebcd41d38.
>
> It wasn't missed, it was deliberately left out because I didn't understand
> what's going on there.
>
> I mean, sysctl handler touching ->f_pos, come on!
>
> What's going on?
>
It is just a normal /proc/sys file. You can write a string to it to change the
some caching mode somehow.
Jan
> > --- a/arch/frv/kernel/sysctl.c
> > +++ b/arch/frv/kernel/sysctl.c
> > @@ -85,7 +86,7 @@ static int procctl_frv_cachemode(ctl_table *table, int write, struct file *filp,
> > }
> >
> > /* read the state */
> > - if (filp->f_pos > 0) {
> > + if (*ppos > 0) {
> > *lenp = 0;
> > return 0;
> > }
Regards,
Jan
--
Jan Blunck <jblunck@suse.de>
next prev parent reply other threads:[~2010-04-12 8:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 14:00 [PATCH 00/12] Multiple file->f_pos/nonseekable_open/llseek fixes (reposy) Jan Blunck
2010-04-09 14:00 ` [PATCH 01/12] osst: Update ppos instead of using file->f_pos Jan Blunck
2010-04-09 14:00 ` [PATCH 02/12] flash_read should update ppos instead of file->f_pos Jan Blunck
2010-04-09 14:00 ` [PATCH 03/12] eeprom_read()/eeprom_write() " Jan Blunck
2010-04-09 14:00 ` [PATCH 04/12] frv: remove "struct file *" argument from sysctl ->proc_handler Jan Blunck
2010-04-09 16:23 ` Alexey Dobriyan
2010-04-12 8:11 ` Jan Blunck [this message]
2010-04-09 14:00 ` [PATCH 05/12] mISDN: Remove unnecessary test on f_pos Jan Blunck
2010-04-09 14:00 ` [PATCH 06/12] zcrypt: Use nonseekable_open() Jan Blunck
2010-04-09 14:00 ` [PATCH 07/12] rtc-m41t80: " Jan Blunck
2010-04-09 14:00 ` [PATCH 08/12] Introduce noop_llseek() Jan Blunck
2010-04-09 14:00 ` [PATCH 09/12] osst: Use noop_llseek() instead of default_llseek() Jan Blunck
2010-04-09 14:00 ` [PATCH 10/12] st: " Jan Blunck
2010-04-09 14:00 ` [PATCH 11/12] Do not fallback to default_llseek() when readdir() uses BKL Jan Blunck
2010-04-09 14:00 ` [PATCH 12/12] Documentation/filesystems/Locking: Update documentation on llseek() wrt BKL Jan Blunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100412081100.GZ10776@bolzano.suse.de \
--to=jblunck@suse.de \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®