mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: David VomLehn <dvomlehn@cisco.com>
Cc: linux-arch@vger.kernel.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/23] Make register values available to CRIS panic notifiers
Date: Mon, 12 Apr 2010 21:08:59 +0200	[thread overview]
Message-ID: <20100412190840.GB17147@merkur.ravnborg.org> (raw)
In-Reply-To: <20100412060625.GA25426@dvomlehn-lnx2.corp.sa.net>

On Sun, Apr 11, 2010 at 11:06:25PM -0700, David VomLehn wrote:
> The save_ptregs() function has not been tested or even built. I will need
> help to complete this.
> 
> Signed-off-by: David VomLehn <dvomlehn@cisco.com>
> ---
>  arch/cris/include/arch-v10/arch/ptrace.h |   80 ++++++++++++++++++++++++++++
>  arch/cris/include/arch-v32/arch/ptrace.h |   84 ++++++++++++++++++++++++++++++
>  2 files changed, 164 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/cris/include/arch-v10/arch/ptrace.h b/arch/cris/include/arch-v10/arch/ptrace.h
> index 2f464ea..28be57c 100644
> --- a/arch/cris/include/arch-v10/arch/ptrace.h
> +++ b/arch/cris/include/arch-v10/arch/ptrace.h
> @@ -114,6 +114,86 @@ struct switch_stack {
>  #define profile_pc(regs) instruction_pointer(regs)
>  extern void show_regs(struct pt_regs *);
>  
> +/* Macros for saving the contents of registers and for the output constraint
> + * for those registers */
> +#include "/home/vomlehn/git/kernel.org/ptreg.h"

The above include needs fixing.
I did not look at the rest of your patches - they may suffer the same.

PS: Your To: is seriously broken, I have to hand-edit Cc:s to send the mail

	Sam

  reply	other threads:[~2010-04-12 19:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-12  6:06 David VomLehn
2010-04-12 19:08 ` Sam Ravnborg [this message]
2010-04-14 21:13   ` David VomLehn
  -- strict thread matches above, loose matches on Subject: below --
2010-04-12  6:03 David VomLehn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100412190840.GB17147@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=dvomlehn@cisco.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®