Re: Security: Replace dac_mmap_min_addr to mmap_min_addr in cap_file_mmap()

[Amerigo Wang <xiyou.wangcong@gmail.com>]

On Wed, Apr 14, 2010 at 01:50:40PM +0800, wzt wzt wrote:
>still not understand,  if CONFIG_LSM_MMAP_MIN_ADDR is not set,
>mmap_min_addr is equal dac_mmap_min_addr, right?
>if not, mmap_min_addr is set as CONFIG_LSM_MMAP_MIN_ADDR.  what's the
>effect of mmap_min_addr?  except round_hint_to_min() will use
>mmap_min_addr, any other functions will call it?

round_hint_to_min() will be called by mmap().

As the names tell you, mmap_min_addr will be checked by mmap(),
dac_mmap_min_addr will be checked for CAP_SYS_RAWIO.

Please check commit 788084ab, as Eric suggested.

>Anyway, the comments need change mmap_min_addr as dac_mmap_min_addr,
>right? If i'm wrong, please point it, thanks.
>/*
> * If the process is attempting to map memory below mmap_min_addr they need   |{
> * CAP_SYS_RAWIO.
> */
>

Yes, I think the comment needs to be fixed.

Thanks.