Re: [PATCH] Input: add HP Compaq 2710p to 'noloop' table

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

On Wed, 14 Apr 2010 14:41:11 +0200 (CEST)
Jiri Kosina <jkosina@suse.cz> wrote:

> On Wed, 14 Apr 2010, Matthew Garrett wrote:
> 
> > On Wed, Apr 14, 2010 at 02:16:25PM +0200, Jiri Kosina wrote:
> > > +		.matches = {
> > > +			DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > > +			DMI_MATCH(DMI_PRODUCT_NAME, "HP Compaq 2710p (#ABD)"),
> > > +			DMI_MATCH(DMI_PRODUCT_VERSION, "F.14"),
> > 
> > Is this really the only BIOS version affected? It seems unlikely. 
> 
> I don't know, it's the only one I have received the report against (I 
> don't own the machine myself).
> 
> > It's also a pretty good indication that we're doing something wrong.
> 
> What do you mean exactly?
> 
> Sending AUX_LOOP is valid thing to do with i8042 controller. If it causes 
> such confusion that the controller doesn't function properly any more, 
> it's clearly broken.

You are assuming there is anything resembling an i8042 in the system.
There may not be, and even if there is there may be SMM code running in
front of it.

It's not really that unlikely that an AUX handling bug exists and only on
one BIOS version given we've seen things as neat as i8042 emulation that
only works on CPU #0 8)

Alan