mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen)
To: Matteo Croce <technoboy85@gmail.com>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: AMD Geode i686
Date: Thu, 15 Apr 2010 13:11:11 -0400	[thread overview]
Message-ID: <20100415171111.GA32023@caffeine.csclub.uwaterloo.ca> (raw)
In-Reply-To: <40101cc31003011403x4423cb3em1f6fcb04d64dd2bb@mail.gmail.com>

On Mon, Mar 01, 2010 at 11:03:09PM +0100, Matteo Croce wrote:
> Hi,
> I have refreshed my AMD Geode i686 patch with NOPL and I have added a
> new nice feature.
> When a NOPL is found the parser looks for any NOPL after the current
> one, so they are emulated in bulk.
> Tested ok on a Pcengines Alix.
> 
> Signed-off-by: Matteo Croce <technoboy85@gmail.com>
> 
> --- a/arch/x86/kernel/Makefile	2010-03-01 01:18:51.697166322 +0100
> +++ b/arch/x86/kernel/Makefile	2010-03-01 01:19:45.727095700 +0100
> @@ -89,6 +89,8 @@
>  obj-$(CONFIG_HPET_TIMER) 	+= hpet.o
> 
>  obj-$(CONFIG_K8_NB)		+= k8.o
> +obj-$(CONFIG_MGEODEGX1)		+= nopl_emu.o
> +obj-$(CONFIG_MGEODE_LX)		+= nopl_emu.o
>  obj-$(CONFIG_DEBUG_RODATA_TEST)	+= test_rodata.o
>  obj-$(CONFIG_DEBUG_NX_TEST)	+= test_nx.o
> 
> --- a/arch/x86/kernel/cpu/amd.c	2010-03-01 01:18:51.737097341 +0100
> +++ b/arch/x86/kernel/cpu/amd.c	2010-03-01 01:19:27.867865836 +0100
> @@ -138,8 +138,10 @@
>  	}
> 
>  	if (c->x86_model == 10) {
> -		/Index: linux-2.6.33/arch/x86/kernel/Makefile
> ===================================================================
> * AMD Geode LX is model 10 */
> -		/* placeholder for any needed mods */
> +		/* Geode only lacks the NOPL instruction to be i686,
> +		   but we can emulate it in the exception handler
> +		   and promote it to a class 6 cpu */
> +		boot_cpu_data.x86 = 6;
>  		return;
>  	}
>  }
> --- a/arch/x86/kernel/entry_32.S	2010-03-01 01:18:51.717096708 +0100
> +++ b/arch/x86/kernel/entry_32.S	2010-03-01 01:19:27.867865836 +0100
> @@ -960,7 +960,11 @@
>  	RING0_INT_FRAME
>  	pushl $0
>  	CFI_ADJUST_CFA_OFFSET 4
> +#ifdef CONFIG_MGEODE_LX
> +	pushl $do_nopl_emu
> +#else
>  	pushl $do_invalid_op
> +#endif

How does this work for MGEODEGX1 when it looks for MGEODE_LX?  It seems
you made both link against the code above after all.  Is this wrong or
the above?

Can it not work if you want to run a generic kernel on your Geode rather
than one built explicitly for the LX?  I build one kernel to run on
Geode SC1200 and Geode LX.

-- 
Len Sorensen

  parent reply	other threads:[~2010-04-15 17:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-01 22:03 Matteo Croce
2010-03-01 23:43 ` Brian Gerst
2010-03-01 23:49   ` H. Peter Anvin
2010-04-15 17:11 ` Lennart Sorensen [this message]
2010-04-15 17:20   ` Matteo Croce
2010-04-15 17:32     ` Lennart Sorensen
2010-04-15 17:36       ` Matteo Croce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100415171111.GA32023@caffeine.csclub.uwaterloo.ca \
    --to=lsorense@csclub.uwaterloo.ca \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=technoboy85@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®