From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: raise.sail@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: A possible bug in reqsk_queue_hash_req()
Date: Tue, 20 Apr 2010 14:24:05 -0700 (PDT) [thread overview]
Message-ID: <20100420.142405.228805796.davem@davemloft.net> (raw)
In-Reply-To: <1271761611.3845.223.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 20 Apr 2010 13:06:51 +0200
> I believe its not really necessary, because we are the only possible
> writer at this stage.
>
> The write_lock() ... write_unlock() is there only to enforce a
> synchronisation with readers.
>
> All callers of this reqsk_queue_hash_req() must have the socket locked
Right.
In fact there are quite a few snippets around the networking
where we use this trick of only locking around the single
pointer assignment that puts the object into the list.
And they were all written by Alexey Kuznetsov, so they must
be correct :-)
next prev parent reply other threads:[~2010-04-20 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 10:35 Li Yu
2010-04-20 11:06 ` Eric Dumazet
2010-04-20 21:24 ` David Miller [this message]
2010-04-20 21:29 ` Eric Dumazet
[not found] ` <u2m9b948ee41004200621zf829996y813c37c5f6a3691f@mail.gmail.com>
[not found] ` <1271775681.7895.21.camel@edumazet-laptop>
2010-04-21 2:02 ` Li Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100420.142405.228805796.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raise.sail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®