From: Amerigo Wang <xiyou.wangcong@gmail.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net,
Jeff Dike <jdike@addtoit.com>
Subject: Re: [PATCH 2/5] uml: Drop private round_down definition
Date: Tue, 20 Apr 2010 16:33:58 +0800 [thread overview]
Message-ID: <20100420083358.GD4356@cr0.nay.redhat.com> (raw)
In-Reply-To: <74c7d668690f283cf3b8aed92004dc72e872f7ce.1271713955.git.jan.kiszka@web.de>
On Mon, Apr 19, 2010 at 11:53:05PM +0200, Jan Kiszka wrote:
>Already defined in kernel.h. The official version assumes that 'n' is
>power of two - which it is in our case.
>
>Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
>---
> arch/um/sys-x86_64/signal.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
>diff --git a/arch/um/sys-x86_64/signal.c b/arch/um/sys-x86_64/signal.c
>index 1a899a7..07797d1 100644
>--- a/arch/um/sys-x86_64/signal.c
>+++ b/arch/um/sys-x86_64/signal.c
>@@ -165,8 +165,6 @@ struct rt_sigframe
> struct _fpstate fpstate;
> };
>
>-#define round_down(m, n) (((m) / (n)) * (n))
>-
> int setup_signal_stack_si(unsigned long stack_top, int sig,
> struct k_sigaction *ka, struct pt_regs * regs,
> siginfo_t *info, sigset_t *set)
Shouldn't this signal.c #include <linux/kernel.h>?
Thanks.
next prev parent reply other threads:[~2010-04-20 8:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 21:53 [PATCH 0/5] uml: Some trivial cleanups Jan Kiszka
2010-04-19 21:53 ` [PATCH 1/5] uml: Remove unused variable from line driver Jan Kiszka
2010-04-20 8:32 ` Amerigo Wang
2010-04-20 14:31 ` Jiri Kosina
2010-04-19 21:53 ` [PATCH 2/5] uml: Drop private round_down definition Jan Kiszka
2010-04-20 8:33 ` Amerigo Wang [this message]
2010-04-20 14:25 ` Jeff Dike
2010-04-20 15:49 ` Jiri Kosina
2010-04-20 14:35 ` Jiri Kosina
2010-04-20 16:52 ` [uml-devel] " Jeff Dike
2010-04-20 17:18 ` Jiri Kosina
2010-04-19 21:53 ` [PATCH 3/5] uml: Fix warning due to missing task_struct declaration Jan Kiszka
2010-04-20 10:09 ` Amerigo Wang
2010-04-20 14:30 ` Jeff Dike
2010-04-20 17:09 ` Jan Kiszka
2010-04-20 23:43 ` Jiri Kosina
2010-04-21 6:06 ` Amerigo Wang
2010-04-21 9:38 ` Jiri Kosina
2010-04-21 10:43 ` Amerigo Wang
2010-04-21 10:49 ` Jiri Kosina
2010-04-19 21:53 ` [PATCH 4/5] uml: i386: Avoid redefinition of NR_syscalls Jan Kiszka
2010-04-20 10:10 ` Amerigo Wang
2010-04-20 17:14 ` Jan Kiszka
2010-04-21 6:12 ` Amerigo Wang
2010-05-10 21:38 ` Jiri Kosina
2010-04-19 21:53 ` [PATCH 5/5] uml: Clean up asm/system.h Jan Kiszka
2010-04-20 10:14 ` Amerigo Wang
2010-04-20 14:33 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100420083358.GD4356@cr0.nay.redhat.com \
--to=xiyou.wangcong@gmail.com \
--cc=jan.kiszka@web.de \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome