mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kyle McMartin <kmcmartin@redhat.com>
To: eparis@redhat.com
Cc: kees@canonical.com, cebbert@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH] trivial: make mmap_min_addr perms 600
Date: Wed, 21 Apr 2010 10:00:33 -0400	[thread overview]
Message-ID: <20100421140033.GA8389@ihatethathostname.lab.bos.redhat.com> (raw)

Chuck points out that mmap_min_addr is 644...

CAP_SYS_RAWIO will deny users read/write to the file, let's let them see
that this is intended.

Signed-off-by: Kyle McMartin <kyle@redhat.com>
---
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 8686b0f..5868481 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1209,7 +1209,7 @@ static struct ctl_table vm_table[] = {
 		.procname	= "mmap_min_addr",
 		.data		= &dac_mmap_min_addr,
 		.maxlen		= sizeof(unsigned long),
-		.mode		= 0644,
+		.mode		= 0600,
 		.proc_handler	= mmap_min_addr_handler,
 	},
 #endif

             reply	other threads:[~2010-04-21 14:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 14:00 Kyle McMartin [this message]
2010-04-21 14:04 ` Eric Paris
2010-04-21 18:29 ` Kees Cook
2010-04-22 15:20   ` Kyle McMartin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100421140033.GA8389@ihatethathostname.lab.bos.redhat.com \
    --to=kmcmartin@redhat.com \
    --cc=cebbert@redhat.com \
    --cc=eparis@redhat.com \
    --cc=kees@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®