From: Masami Hiramatsu <mhiramat@redhat.com>
To: Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
lkml <linux-kernel@vger.kernel.org>
Cc: Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Mike Galbraith <efault@gmx.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
systemtap <systemtap@sources.redhat.com>,
DLE <dle-develop@lists.sourceforge.net>
Subject: [PATCH -tip 3/4] perf probe: Fix to exit callback soon after finding too many probe points
Date: Wed, 21 Apr 2010 15:56:32 -0400 [thread overview]
Message-ID: <20100421195632.24664.42598.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20100421195616.24664.89980.stgit@localhost6.localdomain6>
Fix to exit callback soon after finding too many probe points.
Don't try to continue searching because it already failed.
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
---
tools/perf/util/probe-finder.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
index 3e79775..57b51ca 100644
--- a/tools/perf/util/probe-finder.c
+++ b/tools/perf/util/probe-finder.c
@@ -922,6 +922,8 @@ static int probe_point_inline_cb(Dwarf_Die *in_die, void *data)
(uintmax_t)pf->addr);
param->retval = convert_probe_point(in_die, pf);
+ if (param->retval < 0)
+ return DWARF_CB_ABORT;
}
return DWARF_CB_OK;
@@ -1157,6 +1159,8 @@ static int line_range_funcdecl_cb(Dwarf_Die *sp_die, void *data)
return DWARF_CB_OK;
param->retval = line_range_add_line(src, lineno, lf->lr);
+ if (param->retval < 0)
+ return DWARF_CB_ABORT;
return DWARF_CB_OK;
}
--
Masami Hiramatsu
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2010-04-21 19:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 19:56 [PATCH -tip 1/4] [BUGFIX] perf tools: Initialize dso->node member in dso__new Masami Hiramatsu
2010-04-21 19:56 ` [PATCH -tip 2/4] perf probe: Fix to use symtab only if no debuginfo Masami Hiramatsu
2010-04-26 12:48 ` Arnaldo Carvalho de Melo
2010-04-26 18:59 ` Masami Hiramatsu
2010-04-26 19:08 ` Arnaldo Carvalho de Melo
2010-04-26 19:10 ` Masami Hiramatsu
2010-04-27 12:58 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-04-21 19:56 ` Masami Hiramatsu [this message]
2010-04-27 12:58 ` [tip:perf/core] perf probe: Fix to exit callback soon after finding too many probe points tip-bot for Masami Hiramatsu
2010-04-21 19:56 ` [PATCH -tip 4/4] perf probe: Add --max-probes option Masami Hiramatsu
2010-04-27 12:59 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-04-26 14:01 ` [PATCH -tip 1/4] [BUGFIX] perf tools: Initialize dso->node member in dso__new Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100421195632.24664.42598.stgit@localhost6.localdomain6 \
--to=mhiramat@redhat.com \
--cc=acme@redhat.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome