From: Greg KH <gregkh@suse.de>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: What's the staging review and acceptance process?
Date: Wed, 21 Apr 2010 22:49:02 -0700 [thread overview]
Message-ID: <20100422054902.GA28037@suse.de> (raw)
In-Reply-To: <1271910357.1730.627.camel@Joe-Laptop.home>
On Wed, Apr 21, 2010 at 09:25:57PM -0700, Joe Perches wrote:
> On Wed, 2010-04-21 at 20:45 -0700, Greg KH wrote:
> > That caused the huge backlog staring at
> > me right now.
>
> Which likely discouraged the new contributors who
> submitted stuff still in that backlog.
While a series of unfortunate events did happen to cause this, do you
have any evidence of this causing people to go away? I have had a
number of queries about pending patches, all of which I quickly
responded to (travel being easy to write emails, just not do "real"
work).
> > I just went through 100 patches, and only 40 of them
> > were "valid" and able to be applied, so it is a high rejection rate
> > which requires a lot of attention to be paid to them.
> >
> > > What is your current review/notify/accept/reject workflow?
> >
> > Like it's always been:
> > - patch comes in
> > - I get around to reviewing it
> > - if valid, I apply and you get an email
> > - if invalid, I reject and say why in email
>
> Unfortunately, your process has been opaque until you
> personally handle it.
Yes, like all subsystem maintainers, right?
> Does the driverdev list or any list always receive a copy
> or the feedback?
If it was copied, yes, it does. I can't control who the original
submitters copy on their emails, but they usually do hit the driverdev
mailing list for the most part.
> > > Perhaps a patchwork queue for staging might help track these
> > > patches and with more feedback or reviewers, get them in
> > > shape to be applied.
>
> > patchwork doesn't work well for my patch flow, but maybe that is because
> > I haven't spent enough time with it. Right now I have all the patches,
> > it's just a matter of getting through them.
>
> Maybe you should get some advice on using patchwork use
> from somebody like David Miller, who gets rather more
> patches for networking than staging gets. The patchwork
> queue for networking always seems managed and it can use
> delegation, which your process doesn't seem capable of
> doing. You're a voluntary bottleneck for staging, I
> think you either need to find personal cycles or find
> some other suckers willing to volunteer who'd make up
> more overall cycles.
Are you volunteering?
thanks,
greg k-h
next prev parent reply other threads:[~2010-04-22 5:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 20:32 Joe Perches
2010-04-22 3:45 ` Greg KH
2010-04-22 4:25 ` Joe Perches
2010-04-22 5:49 ` Greg KH [this message]
2010-04-22 5:55 ` Joe Perches
2010-04-22 6:12 ` Greg KH
2010-04-22 6:28 ` Joe Perches
2010-04-22 6:35 ` Jaya Kumar
2010-04-22 6:42 ` Olivier Galibert
2010-04-22 19:58 ` John W. Linville
2010-04-22 20:06 ` Randy Dunlap
2010-04-22 20:17 ` Greg KH
2010-04-22 9:25 ` Stefan Richter
2010-04-22 9:17 ` Alan Cox
2010-04-22 20:18 ` Greg KH
2010-04-22 22:46 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100422054902.GA28037@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome