From: Yoichi Yuasa <yuasa@linux-mips.org>
To: Greg Kroah-Hartman <greg@kroah.com>
Cc: yuasa@linux-mips.org, Naren Sankar <nsankar@broadcom.com>,
Jarod Wilson <jarod@wilsonet.com>,
Scott Davilla <davilla@4pi.com>,
Manu Abraham <abraham.manu@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 04/11] staging: crystalhd: mark all local functions static
Date: Sun, 25 Apr 2010 22:23:21 +0900 [thread overview]
Message-ID: <20100425222321.3f0181b9.yuasa@linux-mips.org> (raw)
In-Reply-To: <20100425221851.223dc284.yuasa@linux-mips.org>
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
---
drivers/staging/crystalhd/crystalhd_lnx.c | 23 ++++++++++++-----------
drivers/staging/crystalhd/crystalhd_lnx.h | 4 ----
2 files changed, 12 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c
index 6ef54e3..a68b5ff 100644
--- a/drivers/staging/crystalhd/crystalhd_lnx.c
+++ b/drivers/staging/crystalhd/crystalhd_lnx.c
@@ -23,6 +23,11 @@ static struct class *crystalhd_class;
static struct crystalhd_adp *g_adp_info;
+static struct crystalhd_adp *chd_get_adp(void)
+{
+ return g_adp_info;
+}
+
static irqreturn_t chd_dec_isr(int irq, void *arg)
{
struct crystalhd_adp *adp = (struct crystalhd_adp *) arg;
@@ -72,7 +77,8 @@ static int chd_dec_disable_int(struct crystalhd_adp *adp)
return 0;
}
-crystalhd_ioctl_data *chd_dec_alloc_iodata(struct crystalhd_adp *adp, bool isr)
+static crystalhd_ioctl_data *chd_dec_alloc_iodata(struct crystalhd_adp *adp,
+ bool isr)
{
unsigned long flags = 0;
crystalhd_ioctl_data *temp;
@@ -92,8 +98,8 @@ crystalhd_ioctl_data *chd_dec_alloc_iodata(struct crystalhd_adp *adp, bool isr)
return temp;
}
-void chd_dec_free_iodata(struct crystalhd_adp *adp, crystalhd_ioctl_data *iodata,
- bool isr)
+static void chd_dec_free_iodata(struct crystalhd_adp *adp,
+ crystalhd_ioctl_data *iodata, bool isr)
{
unsigned long flags = 0;
@@ -613,7 +619,7 @@ static int __devinit chd_dec_pci_probe(struct pci_dev *pdev,
}
#ifdef CONFIG_PM
-int chd_dec_pci_suspend(struct pci_dev *pdev, pm_message_t state)
+static int chd_dec_pci_suspend(struct pci_dev *pdev, pm_message_t state)
{
struct crystalhd_adp *adp;
crystalhd_ioctl_data *temp;
@@ -647,7 +653,7 @@ int chd_dec_pci_suspend(struct pci_dev *pdev, pm_message_t state)
return 0;
}
-int chd_dec_pci_resume(struct pci_dev *pdev)
+static int chd_dec_pci_resume(struct pci_dev *pdev)
{
struct crystalhd_adp *adp;
BC_STATUS sts = BC_STS_SUCCESS;
@@ -705,7 +711,7 @@ static struct pci_driver bc_chd_70012_driver = {
#endif
};
-void chd_set_log_level(struct crystalhd_adp *adp, char *arg)
+static void chd_set_log_level(struct crystalhd_adp *adp, char *arg)
{
if ((!arg) || (strlen(arg) < 3))
g_linklog_level = BCMLOG_ERROR | BCMLOG_DATA;
@@ -725,11 +731,6 @@ void chd_set_log_level(struct crystalhd_adp *adp, char *arg)
g_linklog_level = 0;
}
-struct crystalhd_adp *chd_get_adp(void)
-{
- return g_adp_info;
-}
-
static int __init chd_dec_module_init(void)
{
int rc;
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.h b/drivers/staging/crystalhd/crystalhd_lnx.h
index e4cb6c7..f7fb15a 100644
--- a/drivers/staging/crystalhd/crystalhd_lnx.h
+++ b/drivers/staging/crystalhd/crystalhd_lnx.h
@@ -88,8 +88,4 @@ struct crystalhd_adp {
struct pci_pool *fill_byte_pool;
};
-
-struct crystalhd_adp *chd_get_adp(void);
-
#endif
-
--
1.7.1
next prev parent reply other threads:[~2010-04-25 13:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-25 13:18 [PATCH 01/11] staging: crystalhd: remove unused bc_dts_types.h Yoichi Yuasa
2010-04-25 13:21 ` [PATCH 02/11] staging: crystalhd: remove unused definitions in header files Yoichi Yuasa
2010-04-25 13:22 ` [PATCH 03/11] staging: crystalhd: remove unused BC_STATUS codes Yoichi Yuasa
2010-04-25 13:23 ` Yoichi Yuasa [this message]
2010-04-25 13:24 ` [PATCH 05/11] staging: crystalhd: clean up crystalhd_setup_cmd_context() return code Yoichi Yuasa
2010-04-25 13:40 ` [PATCH 06/11] staging: crystalhd: clean up crystalhd_delete_cmd_context() " Yoichi Yuasa
2010-04-25 13:41 ` [PATCH 07/11] staging: cyrstalhd: clean up crystalhd_user_close() " Yoichi Yuasa
2010-04-25 13:41 ` [PATCH 08/11] staging: crystalhd: clean up crystalhd_user_open() " Yoichi Yuasa
2010-04-25 13:42 ` [PATCH 09/11] staging: crystalhd: clean up crystalhd_put_ddr2sleep() " Yoichi Yuasa
2010-04-25 13:42 ` [PATCH 10/11] staging: crystalhd: remove unneeded crystalhd_put_in_reset() " Yoichi Yuasa
2010-04-25 13:42 ` [PATCH 11/11] staging: crystalhd: remove unneeded crystalhd_stop_device() " Yoichi Yuasa
2010-04-29 19:09 ` [PATCH 01/11] staging: crystalhd: remove unused bc_dts_types.h Greg KH
2010-04-29 19:10 ` Greg KH
2010-04-30 0:40 ` Yoichi Yuasa
2010-04-30 1:41 ` Greg KH
2010-04-30 5:14 ` Yoichi Yuasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100425222321.3f0181b9.yuasa@linux-mips.org \
--to=yuasa@linux-mips.org \
--cc=abraham.manu@gmail.com \
--cc=davilla@4pi.com \
--cc=greg@kroah.com \
--cc=jarod@wilsonet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsankar@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome