From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754455Ab0DZWF0 (ORCPT ); Mon, 26 Apr 2010 18:05:26 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:57461 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752396Ab0DZWFZ (ORCPT ); Mon, 26 Apr 2010 18:05:25 -0400 Date: Mon, 26 Apr 2010 23:10:45 +0100 From: Alan Cox To: Joseph Krahn Cc: linux-kernel@vger.kernel.org Subject: Re: parport_pc.c and parport_serial.c need improvements Message-ID: <20100426231045.115d9cd4@lxorguk.ukuu.org.uk> In-Reply-To: References: X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > parport_pc, similar to parport_serial. In any case, it would be nice > to see more comments on why the SuperIO code is designed as it is. I think the superIO code is more 'evolved' than 'designed'. It's something people nailed bits onto in passing rather than structured elegantly. Do what you think is right IMHO. Alan