mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Gorskin Ilya <revent82@gmail.com>
Cc: gregkh@suse.de, hsweeten@visionengravers.com, ss@aao.gov.au,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging:dt3155: fix coding style issue in dt3155_drv.c This is a patch to the dt3155_drv.c file that fixes up a coding style warning and errors found by the checkpatch.pl tool;
Date: Tue, 27 Apr 2010 14:00:29 -0700	[thread overview]
Message-ID: <20100427210029.GB5046@kroah.com> (raw)
In-Reply-To: <1268469277-29388-1-git-send-email-revent82@gmail.com>

On Sat, Mar 13, 2010 at 01:34:37PM +0500, Gorskin Ilya wrote:
> @@ -183,241 +183,215 @@ static inline void dt3155_isr( int irq, void *dev_id, struct pt_regs *regs )
>    u32 buffer_addr;
>  
>    /* find out who issued the interrupt */
> -  for ( index = 0; index < ndevices; index++ ) {
> -    if( dev_id == (void*) &dt3155_status[ index ])
> -      {
> -	minor = index;
> +    for (index = 0; index < ndevices; index++) {
> +	if (dev_id == (void *) &dt3155_status[index]) {
> +		minor = index;

This fixes up the {} usage, but not the tabs/spaces issues, so it is
still incorrect.  Can you fix that up at the same time here?

thanks,

greg k-h

      reply	other threads:[~2010-04-27 21:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-13  8:34 Gorskin Ilya
2010-04-27 21:00 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100427210029.GB5046@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=revent82@gmail.com \
    --cc=ss@aao.gov.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome