From: Marcelo Tosatti <mtosatti@redhat.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
kvm@vger.kernel.org
Subject: Re: [PATCH] kvm mmu: reduce 50% memory usage
Date: Wed, 28 Apr 2010 15:05:03 -0300 [thread overview]
Message-ID: <20100428180503.GJ18168@amt.cnet> (raw)
In-Reply-To: <4BD8228D.7090708@cn.fujitsu.com>
On Wed, Apr 28, 2010 at 07:57:01PM +0800, Lai Jiangshan wrote:
>
> I think users will enable tdp when their hardwares support ept or npt.
> This patch can reduce about 50% kvm mmu memory usage for they.
>
> This simple patch use the fact that:
>
> When sp->role.direct is set, sp->gfns does not contain any essential
> information, leaf sptes reachable from this sp are for a continuate
> guest physical memory range(a linear range).
> So sp->gfns[i](if it was set) equals to sp->gfn + i. (PT_PAGE_TABLE_LEVEL)
> Obviously, it is not essential information, we can calculate it when need.
>
> It means we don't need sp->gfns when sp->role.direct=1,
> Thus we can save one page usage for every kvm_mmu_page.
>
> Note:
> Access to sp->gfns must be wrapped by kvm_mmu_page_get_gfn()
> or kvm_mmu_page_set_gfn().
> It is only exposed in FNAME(sync_page).
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Applied, thanks.
next prev parent reply other threads:[~2010-04-28 18:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 11:57 Lai Jiangshan
2010-04-28 13:01 ` Avi Kivity
2010-04-28 18:05 ` Marcelo Tosatti [this message]
2010-04-29 18:09 ` Marcelo Tosatti
2010-04-29 18:43 ` Avi Kivity
[not found] ` <4BDA3F9B.8040708@cn.fujitsu.com>
2010-04-30 7:26 ` Avi Kivity
[not found] ` <4BDA9AAC.6060303@cn.fujitsu.com>
2010-04-30 10:00 ` Avi Kivity
2010-04-30 15:44 ` Marcelo Tosatti
2010-05-06 7:03 ` Lai Jiangshan
2010-05-06 19:04 ` Marcelo Tosatti
2010-05-07 8:25 ` Lai Jiangshan
2010-05-07 20:14 ` Marcelo Tosatti
2010-05-26 8:48 ` [RESEND PATCH 2/3] kvm, tdp: calculate correct base gfn for non-DIR level Lai Jiangshan
2010-05-26 10:15 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100428180503.GJ18168@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome