Re: [RFC PATCH 1/4] Mobile security processor driver

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

> -struct sep_driver_init_t {
> -       /* start of the 1G of the host memory address that SEP can access */
> -       unsigned long message_addr;
> +  /* new base address */
> +  dma_addr_t   new_base_addr;
> +};

We seem to be going backwards - deformatting code


> +static inline u32 SEP_READ_REGISTER(struct device_context *dev, int reg)
> +{
> +       void __iomem *addr = dev->reg_addr + reg;
> +       return readl_be(addr);
> +}

Re adding wrappers


> +#define SEP_CHANGE_ENDIANNESS(val) \
> +      (((val) >> 24) | (((val) & 0x00FF0000) >> 8) | \
> +      (((val) & 0x0000FF00) << 8) | \
> +      (((val) & 0x000000FF) << 24))

And other goo


>    *  CHANGES:
>    *
> - *  2009.06.26 Initial publish
> + *  2010.01.08 Initial publish

Sorry ?????