mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Roel Van Nyen <roel.vannyen@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, sdietrich@novell.com,
	sonic.adi@gmail.com, jic23@cam.ac.uk, akpm@linux-foundation.org,
	lindner_marek@yahoo.de
Subject: Re: Staging: iio: Fix remaining code style issues
Date: Thu, 29 Apr 2010 12:17:34 -0700	[thread overview]
Message-ID: <20100429191734.GA21615@kroah.com> (raw)
In-Reply-To: <1272562051-2098-1-git-send-email-roel.vannyen@gmail.com>

On Thu, Apr 29, 2010 at 07:27:31PM +0200, Roel Van Nyen wrote:
> fix code style issues
> 
> Signed-of-by: Roel Van Nyen <roel.vannyen@gmail.com>
> Cc: Jonathan Cameron <jic23@cam.ac.uk>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> 
> --- a/drivers/staging/iio/industrialio-core.c
> +++ b/drivers/staging/iio/industrialio-core.c
> @@ -810,7 +810,7 @@ int iio_device_register(struct iio_dev *dev_info)
>  	ret = iio_device_register_eventset(dev_info);
>  	if (ret) {
>  		dev_err(dev_info->dev.parent,
> -			"Failed to register event set \n");
> +			"Failed to register event set\n");
>  		goto error_free_sysfs;
>  	}
>  	if (dev_info->modes & INDIO_RING_TRIGGERED)
> diff --git a/drivers/staging/iio/ring_sw.c b/drivers/staging/iio/ring_sw.c
> index e95b6a4..4981803 100644
> --- a/drivers/staging/iio/ring_sw.c
> +++ b/drivers/staging/iio/ring_sw.c
> @@ -126,8 +126,7 @@ int iio_store_to_sw_ring(struct iio_sw_ring_buffer *ring,
>  		spin_lock(&ring->buf.shared_ev_pointer.lock);
>  
>  		ret = iio_push_or_escallate_ring_event(&ring->buf,
> -						       IIO_EVENT_CODE_RING_100_FULL,
> -						       timestamp);
> +			       IIO_EVENT_CODE_RING_100_FUL, timestamp);

You never tested this fix :(

It breaks the build, please be more careful next time.  I've fixed it
up...

thanks,

greg k-h

      reply	other threads:[~2010-04-30 19:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-29 17:27 [PATCH] " Roel Van Nyen
2010-04-29 19:17 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100429191734.GA21615@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=jic23@cam.ac.uk \
    --cc=lindner_marek@yahoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roel.vannyen@gmail.com \
    --cc=sdietrich@novell.com \
    --cc=sonic.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome