mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Greg KH <greg@kroah.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Axel Lin <axel.lin@gmail.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: linux-next: manual merge of the usb tree with the input tree
Date: Fri, 30 Apr 2010 15:51:08 +1000	[thread overview]
Message-ID: <20100430155108.6847891f.sfr@canb.auug.org.au> (raw)

Hi Greg,

Today's linux-next merge of the usb tree got a conflict in
drivers/input/tablet/acecad.c between commits
2ef2ed597669f5e120d0c51c295f00e34b2f0801 ("Input: acecad - fix incorrect
size parameter in usb_buffer_free") and
5492f6f801c81c9663417cd8e48e759775977c83 ("Input: acecad - simplify
usb_acecad_disconnect()") from the input tree and commit
3cc96f50329227fbf34de2459491901b6ee1c98c ("USB: rename usb_buffer_alloc()
and usb_buffer_free() users") from the usb tree.

I fixed it up (see below) and can carry the fix as necessary.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc drivers/input/tablet/acecad.c
index 37d0539,c047016..0000000
--- a/drivers/input/tablet/acecad.c
+++ b/drivers/input/tablet/acecad.c
@@@ -246,11 -252,13 +246,11 @@@ static void usb_acecad_disconnect(struc
  	struct usb_acecad *acecad = usb_get_intfdata(intf);
  
  	usb_set_intfdata(intf, NULL);
 -	if (acecad) {
 -		usb_kill_urb(acecad->irq);
 -		input_unregister_device(acecad->input);
 -		usb_free_urb(acecad->irq);
 -		usb_free_coherent(interface_to_usbdev(intf), 10, acecad->data, acecad->data_dma);
 -		kfree(acecad);
 -	}
 +
 +	input_unregister_device(acecad->input);
 +	usb_free_urb(acecad->irq);
- 	usb_buffer_free(acecad->usbdev, 8, acecad->data, acecad->data_dma);
++	usb_free_coherent(acecad->usbdev, 8, acecad->data, acecad->data_dma);
 +	kfree(acecad);
  }
  
  static struct usb_device_id usb_acecad_id_table [] = {

             reply	other threads:[~2010-04-30 17:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-30  5:51 Stephen Rothwell [this message]
2010-04-30 14:44 ` Greg KH
2010-04-30  5:51 Stephen Rothwell
2010-04-30 14:44 ` Greg KH
2010-04-30  5:51 Stephen Rothwell
2010-04-30 14:44 ` Greg KH
2012-05-03  4:44 Stephen Rothwell
2012-05-03 21:49 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100430155108.6847891f.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=axel.lin@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®