From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759003Ab0ECNGy (ORCPT ); Mon, 3 May 2010 09:06:54 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:44271 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758868Ab0ECNGx (ORCPT ); Mon, 3 May 2010 09:06:53 -0400 Date: Mon, 3 May 2010 15:06:23 +0200 From: Ingo Molnar To: Borislav Petkov , "H. Peter Anvin" , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Fr??d??ric Weisbecker , Mike Galbraith , Paul Mackerras , Peter Zijlstra , Tom Zanussi Subject: Re: [PATCH 0/5] perf inject + say no to __KERNEL__ only stuff Message-ID: <20100503130623.GB23372@elte.hu> References: <1272841142-26029-1-git-send-email-acme@infradead.org> <20100503062407.GB15241@elte.hu> <4BDE6D5A.6060407@zytor.com> <20100503065416.GD15241@elte.hu> <20100503073749.GA1694@elte.hu> <20100503081313.GA7111@liondog.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100503081313.GA7111@liondog.tnic> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > From: Ingo Molnar > Date: Mon, May 03, 2010 at 09:37:49AM +0200 > > > It broke half of the non-x86 architectures. For example on Sparc defconfig: > > > > In file included from /home/mingo/tip/include/asm-generic/bitops/hweight.h:4, > > from /home/mingo/tip/arch/sparc/include/asm/bitops_32.h:103, > > from /home/mingo/tip/arch/sparc/include/asm/bitops.h:6, > > from /home/mingo/tip/include/linux/bitops.h:17, > > from /home/mingo/tip/include/linux/kernel.h:15, > > from /home/mingo/tip/include/linux/sched.h:54, > > from /home/mingo/tip/arch/sparc/kernel/asm-offsets.c:13: > > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h: In function '__arch_hweight32': > > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h:8: error: implicit declaration of function '__sw_hweight32' > > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h: In function '__arch_hweight16': > > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h:13: error: implicit declaration of function '__sw_hweight16' > > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h: In function '__arch_hweight8': > > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h:18: error: implicit declaration of function '__sw_hweight8' > > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h: In function '__arch_hweight64': > > /home/mingo/tip/include/asm-generic/bitops/arch_hweight.h:23: error: implicit declaration of function '__sw_hweight64' > > > > (the failure on other architectures looks similar) > > Looks like we're missing the __sw_hweightXX prototype definitions in > that include maze. Ingo, which -tip branch is that and can you put it > somewhere for me to test? it's tip:core/hweight. You should be able to do 'git checkout tip/core/hweight' if you have -tip as a remote repository. It's not merged into tip:master at the moment, but you can do it yourself via: git merge tip/core/hweight to get the tree i tested. Thanks, Ingo