From: Jan Kara <jack@suse.cz>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
David Woodhouse <dwmw2@infradead.org>, Jan Kara <jack@suse.cz>,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Alexander Shishkin <virtuoso@slind.org>,
linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mtd: Do not corrupt backing device of device node inode
Date: Wed, 5 May 2010 16:27:07 +0200 [thread overview]
Message-ID: <20100505142707.GA3938@quack.suse.cz> (raw)
In-Reply-To: <1273069039.3702.188.camel@localhost>
On Wed 05-05-10 17:17:19, Artem Bityutskiy wrote:
> On Wed, 2010-05-05 at 11:21 +0300, Kirill A. Shutemov wrote:
> > We cannot modify file->f_mapping->backing_dev_info, because it will corrupt
> > backing device of device node inode, since file->f_mapping is equal to
> > inode->i_mapping (see __dentry_open() in fs/open.c).
> >
> > Let's introduce separate inode for MTD device with appropriate backing
> > device.
> >
> > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> > Acked-by: Jan Kara <jack@suse.cz>
>
> I get the following build error:
>
> [dedekind@eru l2-mtd-2.6]$ make -j8
> O=/home/dedekind/tmp/l2-mtd-2.6-x86_64/
> GEN /home/dedekind/tmp/l2-mtd-2.6-x86_64/Makefile
> CHK include/linux/version.h
> CHK include/generated/utsrelease.h
> Using /home/dedekind/git/l2-mtd-2.6 as source for kernel
> CALL /home/dedekind/git/l2-mtd-2.6/scripts/checksyscalls.sh
> CHK include/generated/compile.h
> CHK include/linux/version.h
> make[3]: `scripts/unifdef' is up to date.
> Building modules, stage 2.
> Kernel: arch/x86/boot/bzImage is ready (#2)
> MODPOST 146 modules
> ERROR: "__iget" [drivers/mtd/mtdchar.ko] undefined!
> ERROR: "inode_lock" [drivers/mtd/mtdchar.ko] undefined!
> make[2]: *** [__modpost] Error 1
> make[1]: *** [modules] Error 2
> make: *** [sub-make] Error 2
>
> __iget and inode_lock are not exported...
Ah, right. igrab() should be used instead of __iget inside the
inode_lock.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2010-05-05 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 8:21 Kirill A. Shutemov
2010-05-05 14:17 ` Artem Bityutskiy
2010-05-05 14:27 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100505142707.GA3938@quack.suse.cz \
--to=jack@suse.cz \
--cc=dedekind1@gmail.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=viro@zeniv.linux.org.uk \
--cc=virtuoso@slind.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®