From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754867Ab0EFKOa (ORCPT ); Thu, 6 May 2010 06:14:30 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:46499 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360Ab0EFKO2 (ORCPT ); Thu, 6 May 2010 06:14:28 -0400 Date: Thu, 06 May 2010 03:14:35 -0700 (PDT) Message-Id: <20100506.031435.235688827.davem@davemloft.net> To: mingo@elte.hu Cc: david.choi@micrel.com, torvalds@linux-foundation.org, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: tip: origin tree boot crash (in the new micrel phy driver) From: David Miller In-Reply-To: <20100506.031040.186321896.davem@davemloft.net> References: <20100505.012750.246538504.davem@davemloft.net> <20100506095940.GA12711@elte.hu> <20100506.031040.186321896.davem@davemloft.net> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Miller Date: Thu, 06 May 2010 03:10:40 -0700 (PDT) > From: Ingo Molnar > Date: Thu, 6 May 2010 11:59:40 +0200 > >> I bisected it back to the following commit: >> >> d05070091849015f8c5b7d55cd75b86ebb61b3ec is the first bad commit >> commit d05070091849015f8c5b7d55cd75b86ebb61b3ec >> Author: David J. Choi >> Date: Thu Apr 29 06:12:41 2010 +0000 >> >> drivers/net/phy: micrel phy driver ... >> Disabling the driver fixes the crash. > > David please fix this crash, thanks. Nevermind, Ingo please test this fix: diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 0cd80e4..e67691d 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -32,6 +32,7 @@ static int kszphy_config_init(struct phy_device *phydev) static struct phy_driver ks8001_driver = { .phy_id = PHY_ID_KS8001, + .name = "Micrel KS8001", .phy_id_mask = 0x00fffff0, .features = PHY_BASIC_FEATURES, .flags = PHY_POLL,