From: peter@piie.net
To: Rahul Chaturvedi <rkc@chromium.org>
Cc: linux-kernel@vger.kernel.org, msb@chromium.org
Subject: Re: [PATCH] CHROMIUM: acerhdf: fix bug when running on Qemu
Date: Thu, 06 May 2010 07:41:55 +0200 [thread overview]
Message-ID: <20100506074155.21054qc65d3dfm2o@webmail.df.eu> (raw)
In-Reply-To: <1273122377-12137-1-git-send-email-rkc@chromium.org>
Quoting Rahul Chaturvedi <rkc@chromium.org>:
> Driver didn't verify the pointers in which it got product information
> back from DMI; on QEMU one of the pointers came back null,
> which made the driver crash and subsequently caused a kernel panic.
>
> Signed-off-by: Rahul Chaturvedi <rkc@chromium.org>
> ---
> drivers/platform/x86/acerhdf.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index 4d922e4..e8ee3b2 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -500,6 +500,11 @@ static int acerhdf_check_hardware(void)
> product = dmi_get_system_info(DMI_PRODUCT_NAME);
>
>
> + if (!vendor || !version || !product) {
> + pr_err("error getting hardware information");
> + return -EINVAL;
> + }
> +
> pr_info("Acer Aspire One Fan driver, v.%s\n", DRV_VER);
>
> if (force_bios[0]) {
> --
> 1.7.0.1
>
>
Acked-by: Peter Feuerer <peter@piie.net>
next parent reply other threads:[~2010-05-06 5:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1273122377-12137-1-git-send-email-rkc@chromium.org>
2010-05-06 5:41 ` peter [this message]
2010-05-06 5:44 ` Rahul Chaturvedi
2010-05-06 20:08 ` Peter Feuerer
2010-05-06 20:49 ` Mandeep Singh Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506074155.21054qc65d3dfm2o@webmail.df.eu \
--to=peter@piie.net \
--cc=linux-kernel@vger.kernel.org \
--cc=msb@chromium.org \
--cc=rkc@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®