From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932066Ab0EFSVL (ORCPT ); Thu, 6 May 2010 14:21:11 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:36205 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752699Ab0EFSVJ (ORCPT ); Thu, 6 May 2010 14:21:09 -0400 Date: Thu, 6 May 2010 11:18:56 -0700 From: Randy Dunlap To: Stephen Rothwell , David Airlie Cc: linux-next@vger.kernel.org, LKML , dri-devel@lists.freedesktop.org Subject: Re: linux-next: Tree for May 6 (nouveau) Message-Id: <20100506111856.ae15cd03.randy.dunlap@oracle.com> In-Reply-To: <20100506151502.f97afe54.sfr@canb.auug.org.au> References: <20100506151502.f97afe54.sfr@canb.auug.org.au> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Auth-Type: Internal IP X-Source-IP: acsinet15.oracle.com [141.146.126.227] X-CT-RefId: str=0001.0A090207.4BE3087C.0141:SCFMA922111,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 May 2010 15:15:02 +1000 Stephen Rothwell wrote: > Hi all, > > Changes since 20100505: When CONFIG_ACPI_BUTTON=m: drivers/built-in.o: In function `nouveau_connector_detect': nouveau_connector.c:(.text+0x1d81cf): undefined reference to `acpi_lid_open' #ifdef CONFIG_ACPI if (!nouveau_ignorelid && !acpi_lid_open()) status = connector_status_unknown; #endif Do you want that to be #ifdef CONFIG_ACPI_BUTTON ? That will still only be built when CONFIG_ACPI_BUTTON=y (not =m). --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***