Re: [RFC PATCHv2 1/7] HSI: Introducing HSI framework

[Randy Dunlap <randy.dunlap@oracle.com>]

On Fri,  7 May 2010 18:18:31 +0300 Carlos Chinea wrote:

> Adds HSI framework in to the linux kernel.
> 
> High Speed Synchronous Serial Interface (HSI) is a
> serial interface mainly used for connecting application
> engines (APE) with cellular modem engines (CMT) in cellular
> handsets.
> 
> HSI provides multiplexing for up to 16 logical channels,
> low-latency and full duplex communication.
> 
> Signed-off-by: Carlos Chinea <carlos.chinea@nokia.com>
> ---
>  drivers/Kconfig         |    2 +
>  drivers/Makefile        |    1 +
>  drivers/hsi/Kconfig     |   13 ++
>  drivers/hsi/Makefile    |    4 +
>  drivers/hsi/hsi.c       |  489 +++++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/hsi/hsi.h |  369 +++++++++++++++++++++++++++++++++++
>  6 files changed, 878 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/hsi/Kconfig
>  create mode 100644 drivers/hsi/Makefile
>  create mode 100644 drivers/hsi/hsi.c
>  create mode 100644 include/linux/hsi/hsi.h
> 
> diff --git a/drivers/Kconfig b/drivers/Kconfig
> index a2b902f..4fe39f9 100644
> --- a/drivers/Kconfig
> +++ b/drivers/Kconfig
> @@ -50,6 +50,8 @@ source "drivers/i2c/Kconfig"
>  
>  source "drivers/spi/Kconfig"
>  
> +source "drivers/hsi/Kconfig"
> +
>  source "drivers/pps/Kconfig"
>  
>  source "drivers/gpio/Kconfig"
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 2c4f277..24ca5bd 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -45,6 +45,7 @@ obj-$(CONFIG_SCSI)		+= scsi/
>  obj-$(CONFIG_ATA)		+= ata/
>  obj-$(CONFIG_MTD)		+= mtd/
>  obj-$(CONFIG_SPI)		+= spi/
> +obj-$(CONFIG_HSI)		+= hsi/
>  obj-y				+= net/
>  obj-$(CONFIG_ATM)		+= atm/
>  obj-$(CONFIG_FUSION)		+= message/
> diff --git a/drivers/hsi/Kconfig b/drivers/hsi/Kconfig
> new file mode 100644
> index 0000000..5af62ce
> --- /dev/null
> +++ b/drivers/hsi/Kconfig
> @@ -0,0 +1,13 @@
> +#
> +# HSI driver configuration
> +#
> +menuconfig HSI
> +	bool "HSI support"

Why is this bool instead of tristate?
IOW, why can it not be built as a loadable module?


> +	---help---
> +	  The "High speed synchronous Serial Interface" is
> +	  synchronous serial interface used mainly to connect
> +	  application engines and cellular modems.
> +
> +if HSI
> +
> +endif # HSI
> diff --git a/drivers/hsi/Makefile b/drivers/hsi/Makefile
> new file mode 100644
> index 0000000..b42b6cf
> --- /dev/null
> +++ b/drivers/hsi/Makefile
> @@ -0,0 +1,4 @@
> +#
> +# Makefile for HSI
> +#
> +obj-$(CONFIG_HSI)	+= hsi.o


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***